Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save_analysis currently does not save cos lat weighting #25

Closed
nicrie opened this issue Oct 11, 2021 · 0 comments · Fixed by #28
Closed

save_analysis currently does not save cos lat weighting #25

nicrie opened this issue Oct 11, 2021 · 0 comments · Fixed by #28
Assignees
@nicrie
Labels
bug Something isn't working

Comments

@nicrie
Copy link
Owner

nicrie commented Oct 11, 2021

Just stumbled over this:

When saving a model via xmca.xarray.save_analysis and cosine latitude weighting was applied (apply_coslat), the current implementation does not invoke xmca.xarray.apply_coslat when the model gets loaded via xmca.xarray.load_analysis thus creating false PCs.

I hope to provide a fix to this soon.
@nicrie nicrie added the bug Something isn't working label Oct 11, 2021
@nicrie nicrie self-assigned this Oct 11, 2021
@nicrie nicrie mentioned this issue Oct 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicrie nicrie

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 1.4.1 nicrie/xmca
1 participant
@nicrie