Make engines requirement less strict #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @connor-baer ! Thanks so much for the pull request, this looks great. I think you're right that the engines could be lowered as really I'm mostly interested in communicating that I'm running the latest LTS (as specified in .nvmrc). So we could update this to be the lowest active LTS version, but since I'm not actively testing that version it may not be the best idea. |
|
I'll merge this in and get a release out. |
NickColley
added a commit
that referenced
this pull request
Feb 15, 2018
- Allow Node.js versions higher than LTS to run jest-axe - [(PR #13)](#13) Thanks @connor-baer
|
Thanks for the quick release! Personally, I don't mind the recent version since I'm running the latest LTS of Node as well. Was just wondering :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
equaltogreater than or equal(→ documentation)Question: Is
v8.9.4really the first version of Node that's supported, or could this be lower?Closes #12.