php_unit_dedicate_assert.rst

Rule php_unit_dedicate_assert

PHPUnit assertions like assertInternalType, assertFileExists, should be used over assertTrue.

Warning

Using this rule is risky

Fixer could be risky if one is overriding PHPUnit's native methods.

Configuration

target

Target version of PHPUnit.

Allowed values: '3.0', '3.5', '5.0', '5.6' and 'newest'

Default value: 'newest'

Examples

Example #1

Default configuration.

--- Original
+++ New
 <?php
 final class MyTest extends \PHPUnit_Framework_TestCase
 {
     public function testSomeTest()
     {
-        $this->assertTrue(is_float( $a), "my message");
-        $this->assertTrue(is_nan($a));
+        $this->assertInternalType('float', $a, "my message");
+        $this->assertNan($a);
     }
 }

Example #2

With configuration: ['target' => '5.6'].

--- Original
+++ New
 <?php
 final class MyTest extends \PHPUnit_Framework_TestCase
 {
     public function testSomeTest()
     {
-        $this->assertTrue(is_dir($a));
-        $this->assertTrue(is_writable($a));
-        $this->assertTrue(is_readable($a));
+        $this->assertDirectoryExists($a);
+        $this->assertIsWritable($a);
+        $this->assertIsReadable($a);
     }
 }

Rule sets

The rule is part of the following rule sets:

• @PHPUnit30Migration:risky with config:

  ['target' => '3.0']

• @PHPUnit32Migration:risky with config:

  ['target' => '3.0']

• @PHPUnit35Migration:risky with config:

  ['target' => '3.5']

• @PHPUnit43Migration:risky with config:

  ['target' => '3.5']

• @PHPUnit48Migration:risky with config:

  ['target' => '3.5']

• @PHPUnit50Migration:risky with config:

  ['target' => '5.0']

• @PHPUnit52Migration:risky with config:

  ['target' => '5.0']

• @PHPUnit54Migration:risky with config:

  ['target' => '5.0']

• @PHPUnit55Migration:risky with config:

  ['target' => '5.0']

• @PHPUnit56Migration:risky with config:

  ['target' => '5.6']

• @PHPUnit57Migration:risky with config:

  ['target' => '5.6']

• @PHPUnit60Migration:risky with config:

  ['target' => '5.6']

• @PHPUnit75Migration:risky with config:

  ['target' => '5.6']

• @PHPUnit84Migration:risky with config:

  ['target' => '5.6']

• @PHPUnit100Migration:risky with config:

  ['target' => '5.6']

Source class

PhpCsFixer\Fixer\PhpUnit\PhpUnitDedicateAssertFixer