[Core] CLAY_TEXT not rendering lines that contain single characters

[Ryzee119]

Clay_LayoutConfig layoutElement1 = {.padding = {4}, .sizing = {.height = CLAY_SIZING_FIT(), .width = CLAY_SIZING_FIT()}};
Clay_TextElementConfig textElement = {.fontId = FONT_ID_BODY_24, .textColor = {255, 255, 255, 255}, .fontSize = 64};
CLAY(CLAY_LAYOUT(layoutElement1)) {
    CLAY_TEXT(CLAY_STRING("Hello\nWorld\nI\nCode\n"), CLAY_TEXT_CONFIG(textElement));
}

Seems somehow related to fontSize and how it scales?
Im using the raylib rendering backend

however changing to fontSize = 32 (for example) appears to fix it

[nicbarker]

Hello 👋
I think it's possible that you've got the syntax slightly confused, CLAY_TEXT is a child element and should go inside the braces, like this:

Clay_TextElementConfig textElement = {.fontId = FONT_ID_BODY_24, .textColor = {255, 255, 255, 255}, .fontSize = 64};
CLAY(CLAY_LAYOUT(layoutElement1)) {
    CLAY_TEXT(CLAY_STRING("Hello\nWorld\nI\nCode\n"), CLAY_TEXT_CONFIG(textElement));
}

[Ryzee119]

Thanks, still wrapping my head around the syntax, problems still occurs however. I updated the issue description with the correct syntax

[nicbarker]

@Ryzee119 that's totally fine! The syntax is a little odd at the moment for sure, we have plans to improve it 🙂

[nicbarker]

Is it alright if I close this issue?

[Ryzee119]

Is it alright if I close this issue?

You can, but the issue is still present with the correct syntax too

[Ryzee119]

clay/clay.h

Line 1707 in 208c7cb

if (length > 1) {

Changing this to >= 1 fixes the issue. Im fairly sure this is how it should be.

I think it appears to work on some scales due to another quirk/bug in the string slices. At some font scaling CLAY_RENDER_COMMAND_TYPE_TEXT is (correctly?) receiving strings broken up by spaces and new lines, however other times it just sends to entire string in one block. This was hiding the bug.

[nicbarker]

@Ryzee119 very nice work finding it!

[nicbarker]

That bug you've described certainly looks very suspicious though, I will dig into the issues at different font sizes.

[Ryzee119]

That bug you've described certainly looks very suspicious though, I will dig into the issues at different font sizes.

Ive found this issue. If a line that contains new line characters is shorter than the container size it just pushes it to the render without parsing the new lines. This is bailing too early. Ill raise a new issue

clay/clay.h

Lines 2370 to 2374 in 208c7cb

	if (textElementData->preferredDimensions.width <= containerElement->dimensions.width) {
	Clay__WrappedTextLineArray_Add(&context->wrappedTextLines, CLAY__INIT(Clay__WrappedTextLine) { containerElement->dimensions, textElementData->text });
	textElementData->wrappedLines.length++;
	continue;
	}

[nicbarker]

Yep I've found it too, already fixing it 😁

[nicbarker]

Tentative fix is here: #192