Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

payable #144

Closed
fulldecent opened this issue Oct 24, 2018 · 6 comments
Closed

payable #144

fulldecent opened this issue Oct 24, 2018 · 6 comments
Assignees

Comments

@fulldecent
Copy link
Collaborator

fulldecent commented Oct 24, 2018

Currently transfer functions & approve do not allow payable function implementations.

This is okay but it should be documented that this is more restrictive than the standard.

https://github.com/0xcert/ethereum-erc721/blob/master/contracts/tokens/NFToken.sol

@MoMannn MoMannn self-assigned this Nov 21, 2018
@MoMannn
Copy link
Collaborator

MoMannn commented Nov 23, 2018

#154

@MoMannn MoMannn closed this as completed Nov 23, 2018
@fulldecent
Copy link
Collaborator Author

Confirmed fixed in latest branch

@fulldecent fulldecent reopened this May 25, 2021
@fulldecent
Copy link
Collaborator Author

This documentation should also be updated in the interfaces.

@MoMannn
Copy link
Collaborator

MoMannn commented Aug 16, 2021

I would add to @dev: This function can be changed to payable.
Since if anyones wants to make it payable he can do that by himself. I would then add to readme that this implementation does not support payable out of the box.

@fulldecent You ok with this?

@fulldecent
Copy link
Collaborator Author

This is good. But should also specifically say there "this implementation is more restrictive than the ERC-721 standard requires" for the avoidance of doubt.

@MoMannn
Copy link
Collaborator

MoMannn commented Aug 20, 2021

#272

@MoMannn MoMannn closed this as completed Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants