Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up of Actor.vi #46

Open
Tom-McQuillan opened this issue Feb 13, 2025 · 2 comments
Open

Clean up of Actor.vi #46

Tom-McQuillan opened this issue Feb 13, 2025 · 2 comments

Comments

@Tom-McQuillan
Copy link
Collaborator

The block diagram of Actor.vi is messy and can be difficult to explain for new users (especially when teaching AF*). After speaking with @niACS at GDevCon, I propose to reorganize the diagram to improve readability while preserving all existing functionality. This refactoring will focus solely on the visual layout of the code, with no changes to the underlying logic or behavior.

* Usually block diagrams under vi.lib are unseen by LabVIEW developers. However, it is important AF students get a solid understanding of Actor.vi to understand why things work the way they do.

Additional context
This issue stems from a presentation I gave at GDevCon where I showed how actor.vi doesn't confirm to best practices and how straightforward changes would improve it.

The following are screenshots I presented at GDevCon, which @niACS followed up with me to implement.
Link to presentation: https://www.youtube.com/watch?v=VUACQwXTXzk&t=1736s

This is the current Actor.vi block diagram
Image

My proposed solution is the following:

Image

With the following layout:

Image

@niACS
Copy link
Collaborator

niACS commented Feb 17, 2025

I approve of this idea. I'd hoped to scoop up this change in my initial prep work, but wasn't able to connect with Tom in time.

@Tom-McQuillan
Copy link
Collaborator Author

Please could you assign me to this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants