Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty <p> tags on the service manual #1092

Closed
3 of 4 tasks
davidhunter08 opened this issue Mar 30, 2021 · 1 comment · Fixed by #1096
Closed
3 of 4 tasks

Empty <p> tags on the service manual #1092

davidhunter08 opened this issue Mar 30, 2021 · 1 comment · Fixed by #1096
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) guidance

Comments

@davidhunter08
Copy link
Contributor

davidhunter08 commented Mar 30, 2021 •
edited
Loading

What

There are some rogue empty <p> tags on the service manual.

To do

  • Investigate issue
  • Update code
  • Code review
  • Release

More information

Issue raised on the service manual slack by @GrilloPress.

image
@davidhunter08 davidhunter08 added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) guidance labels Mar 30, 2021
@davidhunter08 davidhunter08 mentioned this issue Mar 31, 2021
Merged
4 tasks
@davidhunter08 davidhunter08 linked a pull request Mar 31, 2021 that will close this issue
Find and update all non closing <p> #1096
Merged
4 tasks
@davidhunter08
Copy link
Contributor Author

davidhunter08 commented Mar 31, 2021 •
edited
Loading

There were also some <p> tags not being closed causing spacing issues.

Screenshot 2021-03-31 at 09 13 52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) guidance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Find and update all non closing <p> nhsuk/nhsuk-service-manual
1 participant
@davidhunter08