-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Build Times #87
Comments
@carloteran19 the answer is "it depends"… 😅
If this is a local image (with a relative path in Markdown), it loads the local file, so it should be pretty fast. Here is the part of the code where it decides how to get the dimensions and build the target URL: It uses the FastImage Ruby gems, which "finds the size […] of an image given its uri by fetching as little as needed", so it should not impact your build time too much. Is your code available somewhere, or could you share parts of it? |
Hello @nhoizey, thank you for your prompt response. That was really helpful!
For some reason, the plugin was not picking the site.url so it ended up creating HTML tags with http://localhost as the base url. So the images were not loading (or getting uploaded to Cloudinary) when running the site locally.
wich ended up working, but we started having the long build times. After your comment I realized that by adding prepend: "https://our-website-url.com" was telling FastImage to treat our images as remote images (therefore taking longer to build the site).
Also I got a couple of templates that are throwing the following error: And this is the code I wrote for that particular layout/pages: Is there a proper way to use the plugin the way I am intending? |
Great!
It's interesting that you've been able to use
That's strange. Did you get any error message?
It makes sense indeed.
Awesome!
That's great indeed. Actually, we should talk about "uploading", as Cloudinary downloads them from the server.
You should try to use the same folder name (
Could you show also how you defined the BTW, when using a static image path, you don't need curly brackets around it:
Also, isn't it "FacultyBlank", with an "l" before "ty", instead of "FacutyBlank"?
The way you use it should be fine, we'll try to fix the issues. |
First of all, thank you for the Plugin Nicolas!
I just finished implementing 'jekyll-cloudinary' on my site - Everything worked properly, the only issue is that my build-times went from 2 min to 11 min (on production).
I actually replaced img tags for quite a few templates, but I thought it would only fetch/upload those images to Cloudinary when visiting the site. For what I can tell, the plugin fetches every single image on build time? Am I doing something wrong? Is there a way to upload only the images that have not been uplaoded before?
I am using Netlify to deploy my site and storing the images on my repo (GitHub).
The text was updated successfully, but these errors were encountered: