From f11b7a8b331bbc53570993307ef4a70b27800491 Mon Sep 17 00:00:00 2001 From: Jenny Cho Date: Mon, 27 Apr 2020 20:29:56 +0900 Subject: [PATCH 1/2] fix: resolve broken arrow top position(fix #593) --- src/js/view/popup/scheduleDetailPopup.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/js/view/popup/scheduleDetailPopup.js b/src/js/view/popup/scheduleDetailPopup.js index 2c99ed28a..4bfe7d597 100644 --- a/src/js/view/popup/scheduleDetailPopup.js +++ b/src/js/view/popup/scheduleDetailPopup.js @@ -191,6 +191,10 @@ ScheduleDetailPopup.prototype._getYAndArrowTop = function( y -= containerTop; } + if (arrowTop < 0 || arrowTop > layerHeight) { + arrowTop = '50%'; + } + /** * @typedef {Object} YAndArrowTop * @property {number} y - top position of popup layer From 2dbef68c9b5e4367bb25e1ed42a27597e03de534 Mon Sep 17 00:00:00 2001 From: Jenny Cho Date: Tue, 28 Apr 2020 11:12:05 +0900 Subject: [PATCH 2/2] fix: resolve incorrect value(change assign null value) --- src/js/view/popup/scheduleDetailPopup.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/view/popup/scheduleDetailPopup.js b/src/js/view/popup/scheduleDetailPopup.js index 4bfe7d597..1cdd8bf95 100644 --- a/src/js/view/popup/scheduleDetailPopup.js +++ b/src/js/view/popup/scheduleDetailPopup.js @@ -192,7 +192,7 @@ ScheduleDetailPopup.prototype._getYAndArrowTop = function( } if (arrowTop < 0 || arrowTop > layerHeight) { - arrowTop = '50%'; + arrowTop = null; } /**