Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block tracker #5

Closed
KeesCBakker opened this issue May 18, 2023 · 2 comments
Closed

Block tracker #5

KeesCBakker opened this issue May 18, 2023 · 2 comments

Comments

@KeesCBakker
Copy link

KeesCBakker commented May 18, 2023 •
edited
Loading

Hi! Awesome work, this really helps.

I see my adblocker blocking https://cdn.matomo.cloud/portainer-ce.matomo.cloud/matomo.js.

Can we make it a setting that it somehow does not include this JS when tracking is disabled?

Again, awesome job!
@ngxson
Copy link
Owner

ngxson commented May 18, 2023

Hi, thanks for your suggestion. I surprise to know that such script exists in portainer.

Anw, I added the code to get rid of that script in this PR: #6

The latest image has been updated. To see if it works or not, check on console log if you see this line: Blocked insertion of matomo script node

@KeesCBakker KeesCBakker changed the title Block Block tracker May 18, 2023
@KeesCBakker
Copy link
Author

Super well done! Works like a charm. Thanks for getting it out of there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KeesCBakker @ngxson