Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #172

Closed
nguy opened this issue Dec 6, 2016 · 5 comments
Closed

Bug fixes #172

nguy opened this issue Dec 6, 2016 · 5 comments

Comments

@nguy
Copy link
Owner

nguy commented Dec 6, 2016

In testing the last few updates I've identified a few things that I think need to be fixed:
[ ] Change the ManualFilter name to ManualEdit. I believe this is the nomenclature most people know.
[ ] When the region select is turned off, the lines continue to display on plot. When any Mode or Plugin that uses the region selection tool is closed. Remove lines from the plot and redraw the plot.
[ ] Update the _check_entries method in image_text to be more robust.

@gamaanderson
Copy link
Contributor

the first is easy, the third I don't know what else you want there.
The second one is not that clear, since region select is a plugin it self. Nevertheless to make clean up one can re-implement the close event

@nguy
Copy link
Owner Author

nguy commented Dec 7, 2016

What you did will certainly work.
I think we may want to re-institute, but I'm not sure quite how yet.

@gamaanderson
Copy link
Contributor

should we add addressing this as a requirement to version 1.3?

@nguy
Copy link
Owner Author

nguy commented Feb 3, 2017

Definitely the first two items, they should be easy fixes. The 3rd item I think we should put in the same list as the last two PRs that gave structure and will get refinement. We could start a separate issue for post v1.3?

@gamaanderson
Copy link
Contributor

commit gamaanderson@ca01c80 address this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants