Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Newtonsoft to System.Text.Json #40

Closed
Phalanx123 opened this issue Jan 6, 2021 · 6 comments
Closed

Change Newtonsoft to System.Text.Json #40

Phalanx123 opened this issue Jan 6, 2021 · 6 comments

Comments

@Phalanx123
Copy link

Possibly change Newtonsoft usage to System.Text.Json to reduce reliance on third-party libraries?

@ngocnicholas
Copy link
Owner

Will look into it. Thanks.

@Faeldor
Copy link

Faeldor commented Feb 18, 2021

I'd avoid this if you're doing anything more than using Newtonsoft to deserialize. System.Text.Json only support reading Json at this time. For consistency sake I would stick with Newtonsoft until System.Text.Json catches up.

@ngocnicholas
Copy link
Owner

Microsoft is constantly improving System.Text.Json and there has been significant improvements between .Net Core 3.1 and .Net 5.0 and Microsoft has already started planning for .Net 6.0.
With the info above in mind, I'm planning to do the migration in the new release of Airtable.net.

@chris-ux
Copy link

chris-ux commented Feb 11, 2022

Interested in this due to DateOnly and TimeOnly.

Newtonsoft.Json.JsonSerializationException: Error converting value to type System.DateOnly

PR #47

@ngocnicholas
Copy link
Owner

Replaced Newtonsoft.json with System.Text.Json 6.0.2.

@mabead
Copy link

mabead commented Mar 15, 2023

FYI: I tried to upgrade from 1.1.5 to 1.3 but the result does not work because my enum values can't be converted properly by System.Text.Json because this library does not use the EnumMember attribute. See dotnet/runtime#74385 for more details.

I will therefore have to stay with 1.1.5 because of this change of dependency in the AirTable nuget 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants