Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MaxFails default and Add test coverage for UpstreamServers #29

Merged
merged 8 commits into from
Aug 26, 2019
Merged

Fix MaxFails default and Add test coverage for UpstreamServers #29

merged 8 commits into from
Aug 26, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Fix MaxFails in UpstreamServer and StreamUpstreamServer. Previously the default was 0 as opposed to the intended 1.
  • Improve test coverage for UpstreamServer and StreamUpstreamServer. The following cases were added
    • Adding defaultUpstream
    • Setting MaxConns
    • Setting MaxFails
    • Setting FailTimeout

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the bug An issue reporting a potential bug label Aug 20, 2019
@Dean-Coakley Dean-Coakley self-assigned this Aug 20, 2019
pleshakov
pleshakov reviewed Aug 20, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dean-Coakley thx for the PR! Please see my comments

client/nginx.go Outdated Show resolved Hide resolved
tests/client_test.go Outdated Show resolved Hide resolved
pleshakov
pleshakov reviewed Aug 22, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please see my comments

client/nginx.go Outdated Show resolved Hide resolved
Rulox
Rulox approved these changes Aug 23, 2019
View reviewed changes
Copy link

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pleshakov
pleshakov approved these changes Aug 24, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dean-Coakley Dean-Coakley merged commit 73ba1f5 into master Aug 26, 2019
@Dean-Coakley Dean-Coakley deleted the fix-maxfails-add-tests branch August 26, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rulox Rulox Rulox approved these changes

@pleshakov pleshakov pleshakov approved these changes

@bvighnesha bvighnesha Awaiting requested review from bvighnesha

Assignees

@Dean-Coakley Dean-Coakley

Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @pleshakov @Rulox