Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Deploying Multiple Ingress Controllers per Cluster #546

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Allow Deploying Multiple Ingress Controllers per Cluster #546

merged 2 commits into from
Apr 26, 2019

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Apr 23, 2019 •
edited
Loading

Proposed changes

Re: #528
Fixes: #549

All names of resources created by a deployment must be unique.

  • By default helm chart now prepends release name to all resources it creates to ensure no conflicts occur when deploying 2 or more ingress controllers in the same namespace.

  • leaderLockName now set on daemonset

  • Add missing docs about defaultTLS secret to values.yaml

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the bug An issue reporting a potential bug label Apr 23, 2019
@Dean-Coakley Dean-Coakley self-assigned this Apr 23, 2019
@Dean-Coakley Dean-Coakley requested review from pleshakov and Rulox April 23, 2019 12:37
dlapcenko
dlapcenko suggested changes Apr 23, 2019
View reviewed changes
Copy link

@dlapcenko dlapcenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

controller.reportIngressStatus.externalService name mismatch has to be addressed.

deployments/helm-chart/templates/controller-deployment.yaml Show resolved Hide resolved
@dlapcenko
Copy link

dlapcenko commented Apr 24, 2019 •
edited
Loading

@Dean-Coakley could metadata.namespace: {{ .Release.Namespace }} be added to templates as part of this PR please? is necessary for certain deploy processes (spinnaker helm).

@Dean-Coakley Dean-Coakley mentioned this pull request Apr 24, 2019
Closed
@Dean-Coakley
Copy link
Contributor Author

Dean-Coakley commented Apr 24, 2019 •
edited
Loading

@dlapcenko That change is reasonable. We'll land that change in a separate PR shortly - as it's not related to: #528

pleshakov
pleshakov suggested changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestions.

Also, could you update the description of the PR so that it reflects that PR changes?

deployments/helm-chart/Chart.yaml Outdated Show resolved Hide resolved
deployments/helm-chart/templates/rbac.yaml Outdated Show resolved Hide resolved
@Dean-Coakley Dean-Coakley changed the title Fix helm-chart multiple deployments in same namespace Allow Deploying Multiple Ingress Controllers per Cluster Apr 26, 2019
martialonline
martialonline approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@martialonline martialonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@Dean-Coakley Dean-Coakley merged commit 9974b50 into master Apr 26, 2019
@Dean-Coakley Dean-Coakley deleted the feature/multi-ic branch April 26, 2019 16:04
@Rulox Rulox mentioned this pull request May 2, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlapcenko dlapcenko dlapcenko requested changes

@paigr paigr paigr left review comments

@martialonline martialonline martialonline approved these changes

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Awaiting requested review from Rulox

Assignees

@Dean-Coakley Dean-Coakley

Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not possible to install multiple times in different namespaces
5 participants
@Dean-Coakley @dlapcenko @pleshakov @paigr @martialonline