Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request/response modifiers to VS and VSR #1006

Merged
merged 3 commits into from
Jun 25, 2020
Merged

Add request/response modifiers to VS and VSR #1006

merged 3 commits into from
Jun 25, 2020

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented Jun 23, 2020

Proposed changes

This PR includes the ability to rewrite the URI and modify request/response headers for backend services configured using VirtualServer or VirtualServerRoute custom resources by adding a new action to the routes and subroutes Proxy.

@Rulox Rulox self-assigned this Jun 23, 2020
LorcanMcVeigh
LorcanMcVeigh approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@LorcanMcVeigh LorcanMcVeigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :shipit:

pleshakov
pleshakov reviewed Jun 23, 2020
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rulox looks good! I think there is a bug with regex rewrites. Please take a look.

internal/configs/virtualserver_test.go Outdated Show resolved Hide resolved
internal/configs/virtualserver_test.go Outdated Show resolved Hide resolved
internal/configs/virtualserver_test.go Show resolved Hide resolved
@Rulox Rulox merged commit 9bc383c into master Jun 25, 2020
@Rulox Rulox deleted the vs-vsr-modifiers branch June 25, 2020 15:14
@pleshakov pleshakov added the enhancement Pull requests for new features/feature enhancements label Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorcanMcVeigh LorcanMcVeigh LorcanMcVeigh approved these changes

@pleshakov pleshakov pleshakov approved these changes

@lucacome lucacome Awaiting requested review from lucacome

@Dean-Coakley Dean-Coakley Awaiting requested review from Dean-Coakley

Assignees

@Rulox Rulox

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rulox @pleshakov @LorcanMcVeigh