Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tools.go and require Go 1.24 #3181

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Remove tools.go and require Go 1.24 #3181

merged 2 commits into from
Feb 27, 2025

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented Feb 27, 2025

go 1.24 removes the need for tools.go to include extra packages.

Updating the project to use the new tools method, and require Go 1.24 because of this. Also removed a deprecated linter.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


go 1.24 removes the need for tools.go to include extra packages.

Updating the project to use the new tools method, and require Go 1.24 because of this. Also removed a deprecated linter.
@sjberman sjberman requested a review from a team as a code owner February 27, 2025 18:10
@github-actions github-actions bot added dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.14%. Comparing base (e5faeee) to head (eb67512).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3181   +/-   ##
=======================================
  Coverage   86.14%   86.14%           
=======================================
  Files         113      113           
  Lines       11648    11648           
  Branches       62       62           
=======================================
  Hits        10034    10034           
  Misses       1553     1553           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sjberman sjberman enabled auto-merge (squash) February 27, 2025 20:00
@sjberman sjberman merged commit 04c17a2 into main Feb 27, 2025
40 checks passed
@sjberman sjberman deleted the chore/remove-tools branch February 27, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants