Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically update custom nginx data container with new nginx versions #904

Closed
mpstefan opened this issue Jul 24, 2023 · 3 comments · Fixed by #1019
Closed

Automatically update custom nginx data container with new nginx versions #904

mpstefan opened this issue Jul 24, 2023 · 3 comments · Fixed by #1019
Assignees
@ciarams87
Labels
refined Requirements are refined and the issue is ready to be implemented. release-engineering Relates to all release engineering tasks size/small Estimated to be completed within ~2 days
Milestone
v1.0.0

Comments

@mpstefan
Copy link
Collaborator

mpstefan commented Jul 24, 2023 •
edited
Loading

As a user of NKG
I want the data plane image to be automatically updated when nginx is updated
So that the data plane for NKG always includes the latest release of nginx.

Acceptance

  • When the layers of the nginx release change from what we used to build our nginx data container, our nginx data container is updated and published with the updated nginx image.
  • The updated NKG image maintains the same version.
  • Document the NKG readme how our release image for the same version can change and under what circumstances it will change.
@mpstefan mpstefan added this to the v0.6.0 milestone Aug 3, 2023
@mpstefan mpstefan added the blocked Blocked by other issue label Aug 3, 2023
@mpstefan
Copy link
Collaborator Author

mpstefan commented Aug 3, 2023 •
edited
Loading

Blocked by #798

@mpstefan mpstefan added release-engineering Relates to all release engineering tasks blocked Blocked by other issue and removed blocked Blocked by other issue labels Aug 3, 2023
@mpstefan mpstefan removed the blocked Blocked by other issue label Aug 14, 2023
@mpstefan
Copy link
Collaborator Author

Kubernetes Ingress Controller reference: https://github.com/nginxinc/kubernetes-ingress/blob/main/.github/workflows/update-docker-images.yml

@mpstefan mpstefan added size/small Estimated to be completed within ~2 days refined Requirements are refined and the issue is ready to be implemented. labels Aug 14, 2023
@mpstefan
Copy link
Collaborator Author

We need to determine how this change affects our SBOM for our nginx data container.

@ciarams87 ciarams87 self-assigned this Aug 28, 2023
@ciarams87 ciarams87 mentioned this issue Aug 31, 2023
Merged
6 tasks
@ciarams87 ciarams87 modified the milestones: v0.6.0, v1.0.0 Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ciarams87 ciarams87

Labels
refined Requirements are refined and the issue is ready to be implemented. release-engineering Relates to all release engineering tasks size/small Estimated to be completed within ~2 days
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Add workflow for updating nginx base image ciarams87/nginx-gateway-fabric
2 participants
@mpstefan @ciarams87