Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace resources are tracked by Graph #1263

Closed
ja20222 opened this issue Nov 20, 2023 · 0 comments · Fixed by #1320
Closed

Namespace resources are tracked by Graph #1263

ja20222 opened this issue Nov 20, 2023 · 0 comments · Fixed by #1320
Assignees
@bjee19
Labels
refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week tech-debt Short-term pain, long-term benefit
Milestone
v1.2.0

Comments

@ja20222
Copy link

ja20222 commented Nov 20, 2023 •
edited by bjee19
Loading

Currently, relationship.Capturer is used to determine if we need to process Namespace resources.

Because the Graph is a state of the Gateway API and relevant cluster resources, use it as a source to determine relevant Namespace resources, rather than a separate component. This will avoid having duplicated logic to track relationship and make the Graph the source of truth.

See FIXME https://github.com/nginxinc/nginx-kubernetes-gateway/blob/36d5df4f5b047eadcbc2b814f19c216a054c2d6c/internal/state/graph/graph.go#L51

Acceptance criteria:

  • Use the Graph instead of relationship.Capturer for Namespace resources.
@ja20222 ja20222 mentioned this issue Nov 20, 2023
Closed
@ja20222 ja20222 added size/medium Estimated to be completed within a week tech-debt Short-term pain, long-term benefit labels Nov 20, 2023
@ja20222 ja20222 added this to the v1.2.0 milestone Nov 20, 2023
@ja20222 ja20222 added the refined Requirements are refined and the issue is ready to be implemented. label Nov 20, 2023
@bjee19 bjee19 changed the title Namespace Namespace resources tracked by Graph Nov 20, 2023
@bjee19 bjee19 changed the title Namespace resources tracked by Graph Namespace resources are tracked by Graph Nov 20, 2023
@bjee19 bjee19 mentioned this issue Dec 1, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjee19 bjee19

Labels
refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week tech-debt Short-term pain, long-term benefit
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Namespace resources are tracked by graph bjee19/nginx-gateway-fabric
2 participants
@ja20222 @bjee19