Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelisting Annotation? #739

Closed
aharper273 opened this issue Oct 24, 2019 · 1 comment
Closed

Whitelisting Annotation? #739

aharper273 opened this issue Oct 24, 2019 · 1 comment
Labels
proposal An issue that proposes a feature request question An issue asking a question

Comments

@aharper273
Copy link

I do not see a way to add a whitelist of IPs using an annotation. Is this a planned feature?

Something like nginx.org/whitelist-source-range followed by a list of comma-separated IPs? This would be very useful and I have yet to find a way to do it using this ingress.

If this isn't a planned feature, is there a way to do this manually? Would that involve writing a custom annotation and restarting my ingress?

@pleshakov pleshakov added the question An issue asking a question label Oct 24, 2019
@pleshakov
Copy link
Contributor

@aharper273
There are two options for whitelisting in Ingress resources:

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: cafe-ingress
  annotations:
     kubernetes.io/ingress.class: "nginx"
     nginx.org/server-snippets: "allow 192.168.1.3; deny all;"

Is this a planned feature?

We're planning to support policies such as auth, rate-limiting, request/response manipulation in our custom resources https://github.com/nginxinc/kubernetes-ingress/blob/master/docs/virtualserver-and-virtualserverroute.md The polices will include whitelisting. We will be bringing support for polices in 1.7.0 release next year.

@pleshakov pleshakov added the proposal An issue that proposes a feature request label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal An issue that proposes a feature request question An issue asking a question
Projects
None yet
Development

No branches or pull requests

3 participants