Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly retry if format is not expected #516

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Correctly retry if format is not expected #516

merged 1 commit into from
Mar 7, 2019

Conversation

xiamaz
Copy link
Contributor

@xiamaz xiamaz commented Feb 28, 2019

If the format of a CID source is unable to be matched, the next source should be tried.

Also try to exactly match 64bit alnum strings. Which should work be more robust against smaller format changes.

This should fix #514.

@buchdag buchdag merged commit 4b4fd76 into nginx-proxy:master Mar 7, 2019
@buchdag
Copy link
Member

buchdag commented Mar 7, 2019

Many thanks, sorry for the merging delay !

@xiamaz xiamaz deleted the fixcid branch March 8, 2019 09:39
@buchdag buchdag added the kind/bug Issue reporting a bug label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issue reporting a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container ID does not work reliably in fedora atomic systems
2 participants