New environmental variable LETSENCRYPT_RESTART_CONTAINER

[Greek64]

This PR adds an additional functionality via an additional environmental variable.

Containers with the LETSENCRYPT_RESTART_CONTAINER variable set to true will be restarted when their respective certificates are updated/modified.

Fixes #434

[buchdag]

Hi. I haven't forgotten about this PR but I'm still unsure about merging it (because of the project scope issue).

By the way if this is to be merged it'll require a corresponding test unit.

[Greek64]

Yeah, don't worry.
As said, I will try to keep the fork updated for the guys that want this functionality as long as this isn't merged (which may be never).

I didn't think of the test unit.
I will look into that when I have time.

[buchdag]

No hurry for the test unit, at least until we've reached a decision about merging the feature or not.

[Greek64]

I have integrated the functionality into the existing test units (namely certs_single, certs_san, force_renew).

I currently have to versions:

• One for the stable (tag v1.9.1)
• One for master (f936be7)

The thing is, that the test units on master fail on my system (even without me changing anything), and so I am reluctant to push them on these PR branch, until they run on my system.
The stable test units work as expected (but are before you trapped the cleanup routine on exit, i.e. outdated).
So I could force push these PR around the v1.9.1 tag if you would like.

The other thing is, that the actual functionality for which the environmental variable was added (auto-renewal), is currently not even tested (see #477 ).

[Greek64]

Another thing that I noticed in the test units:
Shouldn't the loop in line 34 in the default_certs test unit contain a break?

[buchdag]

Another thing that I noticed in the test units:
Shouldn't the loop in line 34 in the default_certs test unit contain a break?

Yes it should, thanks for spotting that.

I've been lacking spare time for the last few weeks, I'll come back to this PR as soon as I can. Got a few thinks I want to clear first.

[Greek64]

The thing is, that the test units on master fail on my system (even without me changing anything), and so I am reluctant to push them on these PR branch, until they run on my system.

I found the reason why the test units fail locally.
See #482

[Greek64]

I updated the PR to the newest master commit and pushed the new test units.
Now everything passes.

[buchdag]

Okay, I've just reviewed your PR, thanks for your work.

I think a separate test unit for this feature would be more fitting, rather than adding more logic to three existing tests. You could just take the basic cert_single test, remove all the cert verification code and just check that the container is restarted correctly.

Also if your test generate extra files (docker_event_out.txt), don't forget to add them to .gitignore, just in case (even if it has a trapped removal).

[buchdag]

BTW if this wasn't clear this PR will be merged as soon as the last details are ironed out 👍

[Greek64]

Added a separate "container_restart" test unit, and added temp file to .gitignore.

[buchdag]

Whitespace issues ?

[Greek64]

Probably a side effect of "automatic indentation" of my Editor.

[buchdag]

Same here.

[Greek64]

Same as above

[buchdag]

If you can cleanup the two remaining whitespace typos and write a line of doc explaining this feature I think we're good to go.

[Greek64]

If you can cleanup the two remaining whitespace typos and write a line of doc explaining this feature I think we're good to go.

Done