-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fullwidth characters support #460
Comments
@weii41392 thanks for the report and the fix! This has been released in the latest linkifyjs v4.1.3 |
Thank you @nfrasser! But with further testing we found that the current logic doesn't work as expected. Is this intended or can we also modify this behavior? Work as expected
Not work as expected
Different from English, we don't add whitespaces in Chinese (at least in formal writing). That's why |
Currently the parser can recognize opening parentheses and closing parentheses and exclude closing parentheses when appropriate, while we don't have the same behavior with fullwidth characters. See this example:
My proposal is to define fullwidth characters as tokens, and add new behaviors in the parser.
The logic should be fairly simple as fullwidth brackets are semantically the same as their halfwidth counterparts.
(In our use case we care more about fullwidth parentheses
()
, but in general this can apply to other fullwidth characters, e.g.「」『』<>
.)The text was updated successfully, but these errors were encountered: