Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local to tlds.js #101

Closed
mbojey opened this issue Dec 29, 2015 · 4 comments
Closed

Add local to tlds.js #101

mbojey opened this issue Dec 29, 2015 · 4 comments
Assignees
@nfrasser

Comments

@mbojey
Copy link
Contributor

mbojey commented Dec 29, 2015

Would allow linkifying of links like http://neon.myCompany.local:8000/www/Project/latest
@nfrasser nfrasser self-assigned this Dec 29, 2015
@nfrasser
Copy link
Owner

Sure thing, just has to be added to this file in alphabetical order.

@mbojey
Copy link
Contributor Author

mbojey commented Dec 29, 2015

So it looks like you are using local as a domain as well. I guess that means that it can't be used as a TLD? Is there anyway it can be used as both?

@nfrasser
Copy link
Owner

nfrasser commented Jan 4, 2016

I would update the test to make local a TLD. Relevant line is here. The DOMAIN should be changed to TLD.

I apologize for the delay on this, was having trouble accessing Travis earlier to see the issue.

@nfrasser
Copy link
Owner

nfrasser commented Jan 6, 2016

Fixed in #102

@nfrasser nfrasser closed this as completed Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfrasser nfrasser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nfrasser @mbojey