Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream changes to react-side-effect #17

Closed
necolas opened this issue Jul 4, 2015 · 2 comments
Closed

Upstream changes to react-side-effect #17

necolas opened this issue Jul 4, 2015 · 2 comments
Labels
enhancement

Comments

@necolas
Copy link

necolas commented Jul 4, 2015

You could externalise your side-effect module by applying it to react-side-effect as a fix for gaearon/react-side-effect#4
@cwelch5
Copy link
Contributor

cwelch5 commented Jul 21, 2015

Thanks, yes, I had started that PR to take the management of that dependency out of this library. And yes, we've changed it a bit since then, so I updated my fork and updated the PR. Thanks for looking out.

Here's the updated PR: gaearon/react-side-effect#5

@cwelch5
Copy link
Contributor

cwelch5 commented Sep 3, 2015

We've externalized react-side-effect, and are using the latest version. Reflected in Helmet 1.1.3

@cwelch5 cwelch5 closed this as completed Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@necolas @cwelch5