From 371f50ccaaf95fd4636533f0f23816c2cd768ceb Mon Sep 17 00:00:00 2001 From: msroz Date: Wed, 20 Feb 2019 16:22:46 +0900 Subject: [PATCH] Fix exception message when invalid matching. --- lib/retryable.rb | 2 +- spec/retryable_spec.rb | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/retryable.rb b/lib/retryable.rb index 2f5d36b..3b64ed1 100644 --- a/lib/retryable.rb +++ b/lib/retryable.rb @@ -113,7 +113,7 @@ def matches?(message, candidates) when Regexp message =~ candidate else - raise ArgumentError, ':matches must be a string or regex' + raise ArgumentError, ':matching must be a string or regex' end end end diff --git a/spec/retryable_spec.rb b/spec/retryable_spec.rb index 7c627d6..5fc55ee 100644 --- a/spec/retryable_spec.rb +++ b/spec/retryable_spec.rb @@ -134,6 +134,12 @@ expect(counter.count).to eq(4) end + it 'does not allow invalid type of matching option' do + expect do + described_class.retryable(matching: 1) { raise 'this is invaid type of matching iotion' } + end.to raise_error ArgumentError, ':matching must be a string or regex' + end + it 'does not allow invalid options' do expect do described_class.retryable(bad_option: 2) { raise 'this is bad' }