Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Performance of ARCitect GUI goes down massively. #525

Open
arendd opened this issue Sep 23, 2024 · 8 comments
Open

[BUG] Performance of ARCitect GUI goes down massively. #525

arendd opened this issue Sep 23, 2024 · 8 comments
Assignees
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@arendd
Copy link

arendd commented Sep 23, 2024

  • tested on: [Windows 11 and MacOS]

I started creating some example ARCs and realized that the general performance of the application, e.g. when creating a new contact, adding new tables, switching between fields is becoming very laggy and I just added one study with 130 lines and two assays with around 4000 lines. I takes 5 seconds, sometimes more to change a menu or adding new values.

If it helps I can share the ARC for testing, it is in a private group in the PlantDataHub.

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Sep 23, 2024
@JonasLukasczyk JonasLukasczyk self-assigned this Sep 23, 2024
@JonasLukasczyk JonasLukasczyk added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed Status: Needs Triage This item is up for investigation. labels Sep 23, 2024
@JonasLukasczyk
Copy link
Collaborator

Hi, thank you for posting this. Please share the ARC if possible. To nail down the issue: is the actual ARCitect UI becoming leggy or the SWATE view?

@JonasLukasczyk
Copy link
Collaborator

My suspicion is that there is some problem with SWATE. You can test this by opening SWATE in the browser and importing the ISA file you are having trouble with: https://swate-alpha.nfdi4plants.org/.

Please let us know if you see the same problems on the webpage.

@arendd
Copy link
Author

arendd commented Sep 24, 2024

What is the difference between ARCitect UI and Swate? I dont use the Swate plugin, just downloaded the ARCitect app (0.0.40/41) and run it in the desktop on Mac an Windows. I attached the ARC. Where is the "load" button on https://swate-alpha.nfdi4plants.org/ ?
fieldphenotypingwheat.zip

@Freymaurer
Copy link
Collaborator

Hey! The ARCitect uses Swate to render the individual isa files. Everytime you click on one of the isa files in ARCitect it will load the file in an internal Swate version. In Swate standalone you can edit single files. Can you try to edit the largest of your files in the Swate browser version, so we can narrow down which parts might be too slow? Thank you in advance!

@arendd
Copy link
Author

arendd commented Sep 24, 2024

Hey guys, thank you for you help. Unfortunately with https://swate-alpha.nfdi4plants.org/ I can only edit the investigation. How can I add studies and assays? I tried it already with the ARCitect. The Investigaiton is fine, but after adding my studies and assays it become laggy.

@Freymaurer
Copy link
Collaborator

Freymaurer commented Sep 24, 2024

You can delete the currently opened investigation with the trash icon on the top rght of the spreadsheet view and then simply upload the correct isa.study file

@arendd
Copy link
Author

arendd commented Sep 24, 2024

Okay sorry, was a browser cache problem, did not get the "import file" button. Now it works. I tested two assay files with ~4000 respectively ~8000 lines. Both are laggy. They can be loaded, but then already adding a new "Performer" takes very long. I attached both files: isa.assay.xlsx, isa.assay.xlsx

@Freymaurer Freymaurer transferred this issue from nfdi4plants/ARCitect Sep 24, 2024
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Sep 24, 2024
@Freymaurer Freymaurer removed the Status: Needs Triage This item is up for investigation. label Sep 27, 2024
@Freymaurer
Copy link
Collaborator

Hey! With the recent changes to our websites, i sadly had very little time to look into this issue. I am now working on Swate again, and investigating the issue.

At the moment i think, that the mechanism through which Swate handles its undo/redo function is the culprit.

We parse the full file into json format for every change and store this "state" in localStorage. This parsing might be the issue for the performance dips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
Status: Backlog
Development

No branches or pull requests

3 participants