Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEB SARS-CoV-2 primers #356

Closed
tavareshugo opened this issue Feb 16, 2023 · 3 comments
Closed

NEB SARS-CoV-2 primers #356

tavareshugo opened this issue Feb 16, 2023 · 3 comments
Milestone

Comments

@tavareshugo
Copy link
Contributor

The NEB primer BED files on the config file don't seem to exist: here and here.

It might also be worth documenting what vss1 and vsl1 corresponded to in terms of VarSkip primer versions available from NEB (maybe just a comment in the config would be enough).

@maxulysse maxulysse transferred this issue from nf-core/configs Mar 1, 2023
@maxulysse
Copy link
Member

@tavareshugo there is no NEB folder in https://github.com/nf-core/test-datasets/tree/viralrecon/genome/MN908947.3/primer_schemes only artic, I'm pretty sure that's were the issue lies.

Any idea about that @drpatelh ?

@drpatelh
Copy link
Member

drpatelh commented Mar 5, 2023

Oof! The PR adding those files is still open 🤦🏽
nf-core/test-datasets#299

Don't think anyone checked before merging into nf-core/configs:
nf-core/configs#264 (review)

Still need to address my comments on nf-core/test-datasets and then merge for them to become available.

@drpatelh drpatelh added this to the 2.6 milestone Mar 5, 2023
@drpatelh
Copy link
Member

I have pushed some changes and merged nf-core/test-datasets#299

Fixed the URLs and added a comment in the config regarding the different options for NEB: nf-core/configs@9d05c1b

Should be fixed now. Thanks for reporting @tavareshugo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants