Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions CI tests for -profile conda and -profile singularity #815

Open
drpatelh opened this issue Dec 14, 2020 · 2 comments
Open
Assignees
Labels
automation infrastructure modules Related to tools for working with DSL2 modules

Comments

@drpatelh
Copy link
Member

Currently, all of the Github Actions CI tests that we use to test that the pipeline functions (using a minimal dataset) are run as -profile test,docker. This just tests whether the pipeline will run with Docker, however, with the advent of DSL2 the processes we were using to create this Docker image are much more detached because the Conda, Singularity and Docker definitions are now all obtained from different sources. Developers tend to test with one of these methods so it would be great to have CI tests for all of them just to make sure they are working.

For example, I just noticed a Conda conflict issue because I explicitly tested -profile test,conda before releasing the rnaseq pipeline nf-core/rnaseq@c2a7fff.

@maxulysse
Copy link
Member

I'm starting to look into that for sarek.
cf https://github.com/nf-core/sarek/pull/338/checks?check_run_id=1792906176

@ewels ewels added the modules Related to tools for working with DSL2 modules label Apr 13, 2022
@github-project-automation github-project-automation bot moved this to Todo (Hackathon General) in nf-core Hackathon March 2023 Mar 21, 2023
@Sir-Jarvis Sir-Jarvis assigned Sir-Jarvis and unassigned Sir-Jarvis Mar 27, 2023
@sateeshperi
Copy link
Contributor

@drpatelh given that conda tests on CI are unreliable and testing for singularity might be an overkill for the runners, your thoughts on closing this issue?

@ewels ewels removed the DSL2 label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation infrastructure modules Related to tools for working with DSL2 modules
Projects
No open projects
Development

No branches or pull requests

6 participants