Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules pytest migration flag fails to remove symlinked pytest directories #2682

Closed
jfy133 opened this issue Jan 25, 2024 · 1 comment
Closed
Labels
bug Something isn't working
Milestone

Comments

@jfy133
Copy link
Member

jfy133 commented Jan 25, 2024

Description of the bug

Some tools that have a subcommand named build did not work with the pytest implementation of module tests.

The workaround was to make a symlink of the module name from build to something called build_test

(example: MALT/BUILD).

During nf-core modules create malt/build --migrate-pytest) I got an error message saying that it could not remove symlinks, so the migration failed.

This then meant pytest files were still under the test/ directory, and was not removed from the pytest tags yml file.

(Unfortuantely I don't have it on my terminal anymore due to other traceback)

Command used and terminal output

No response

System information

No response

@jfy133 jfy133 added the bug Something isn't working label Jan 25, 2024
@mashehu mashehu added this to the 2.13 milestone Feb 9, 2024
@mirpedrol
Copy link
Member

Done with #2770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants