Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flowcell in readgroup is not resolved #869

Closed
maxulysse opened this issue Nov 25, 2022 · 1 comment
Closed

flowcell in readgroup is not resolved #869

maxulysse opened this issue Nov 25, 2022 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@maxulysse
Copy link
Member

Description of the bug

The ID field should have ${flowcell}.${row.sample}.${row.lane}
flowcell gets resolved to null, so I'm guessing something with the flowcellLaneFromFastq() function.

cf AWS megatests in tower:

INDEX=`find -L ./ -name "*.amb" | sed 's/.amb//'`

bwa mem \
    -K 100000000 -Y -R "@RG\tID:null.HCC1395N.1\tPU:1\tSM:HCC1395_HCC1395N\tLB:HCC1395N\tDS:s3://ngi-igenomes/igenomes/Homo_sapiens/GATK/GRCh38/Sequence/WholeGenomeFasta/Homo_sapiens_assembly38.fasta\tPL:ILLUMINA" \
    -t 16 \
    $INDEX \
    0001.HCC1395N-1_1.fastp.fastq.gz 0001.HCC1395N-1_2.fastp.fastq.gz \
    | samtools sort  --threads 16 -o HCC1395N-1.0001.bam -

cat <<-END_VERSIONS > versions.yml
"NFCORE_SAREK:SAREK:FASTQ_ALIGN_BWAMEM_MEM2_DRAGMAP:BWAMEM1_MEM":
    bwa: $(echo $(bwa 2>&1) | sed 's/^.*Version: //; s/Contact:.*$//')
    samtools: $(echo $(samtools --version 2>&1) | sed 's/^.*samtools //; s/Using.*$//')
END_VERSIONS

Command used and terminal output

No response

Relevant files

No response

System information

No response

@maxulysse maxulysse added the bug Something isn't working label Nov 25, 2022
@maxulysse maxulysse added this to the 3.3 milestone Feb 21, 2023
@github-project-automation github-project-automation bot moved this to Todo (Hackathon General) in nf-core Hackathon March 2023 Mar 21, 2023
@maxulysse maxulysse modified the milestones: 3.3, 3.4, 3.5 Feb 8, 2024
@maxulysse
Copy link
Member Author

solved by #1673

@github-project-automation github-project-automation bot moved this from Planned Bug fixes to Done in Sarek Board Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

1 participant