Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assume pansn-spec in wfmash parameters to enfoce lower-triangular mapping #156

Open
subwaystation opened this issue Oct 27, 2023 · 4 comments
Open

assume pansn-spec in wfmash parameters to enfoce lower-triangular mapping #156

subwaystation opened this issue Oct 27, 2023 · 4 comments
Labels
enhancement Improvement for existing functionality

Comments

@subwaystation
Copy link
Collaborator

Description of feature

Mirror pangenome/pggb@1478789.
@subwaystation subwaystation added the enhancement Improvement for existing functionality label Oct 27, 2023
@subwaystation
Copy link
Collaborator Author

Dependent on #139.

@subwaystation
Copy link
Collaborator Author

subwaystation commented Oct 27, 2023 •
edited
Loading

Add another parameter that optionally allows the input sequences to not follow the pansn-spec. But then require the user to input the number of haplotypes!

@subwaystation
Copy link
Collaborator Author

Also add a warning, if the input sequences are not in pansn-spec. Make it clear that vg deconstruct will fail for sure.

@subwaystation
Copy link
Collaborator Author

With release 1.1.1 we now apply the lower-triangular mapping. The rest we still need to take care of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement for existing functionality
Projects
No open projects
Hackathon: May 2024
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@subwaystation