Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A uniform input for all tools in each screening workflow #385

Open
m3hdad opened this issue Jun 5, 2024 · 2 comments
Open

A uniform input for all tools in each screening workflow #385

m3hdad opened this issue Jun 5, 2024 · 2 comments
Labels
enhancement Improvement for existing functionality

Comments

@m3hdad
Copy link
Contributor

m3hdad commented Jun 5, 2024

Description of feature

Currently different analysis software in ARG screening workflow use different input sequences.
For instance, AMRFinderPlus and RGI use nucleotide sequence as input whereas deeparg uses predicted protein sequences from the annotation step in the beginning of the pipeline.

Since all software accept both nucleotide and protein sequences, it would be really helpful to have a uniform input for all software which allows post-processing and comparison between predictions by different software based on sequence accession number.

https://nfcore.slack.com/archives/C02K5GX2W93/p1717515107461539

@m3hdad m3hdad added the enhancement Improvement for existing functionality label Jun 5, 2024
@Darcy220606
Copy link
Contributor

This feature is also referred to in issue #179. Just to keep track of our issues ;)

@jfy133
Copy link
Member

jfy133 commented Jun 7, 2024

Yes this is a fair point. A little more context, from the one implied by Anan: essentially we want to try and use input that has already been annotated by the pipeline to ensure consistency and efficiency, rather than letting each tool do their own annotation each with a different tool. But that is assuming the tool accepts pre annotated input

So really I would almost want to go in the other direction (I think what the other issue Anan is pointing to ), use amino acid sequence (where possible). That said, we could theoretically make it user choice, but this would require a lot more more channel/conditional code to be added...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants