Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple sets of adapters to be supplied #651

Closed
ashildv opened this issue Jan 7, 2021 · 6 comments · Fixed by #768
Closed

Allow multiple sets of adapters to be supplied #651

ashildv opened this issue Jan 7, 2021 · 6 comments · Fixed by #768
Labels
enhancement New feature or request feature good first issue Good for newcomers minor pending Addressed on branch waiting for related PR
Milestone

Comments

@ashildv
Copy link
Contributor

ashildv commented Jan 7, 2021

Hi there,
I wonder if it would be possible to add a feature in the pipeline allowing libraries made with different adapter sequences to be processed in the same run.

For example, my colleagues and I are often working with a mixture of Illumina and BGI (4 channel) sequencing data and it would be cool to be able run these data together, instead of having to run adapter removal separately for each dataset before combining them in a single run.

@ashildv ashildv added the enhancement New feature or request label Jan 7, 2021
@apeltzer
Copy link
Member

apeltzer commented Jan 8, 2021

Sounds good to me - I fear we might have to check how easy to implement this is but should be possible.

@jfy133
Copy link
Member

jfy133 commented Jan 8, 2021

Adapter removal already does this, planning to do something similar for the barcodes. So should be feasible I believe!

@jfy133
Copy link
Member

jfy133 commented Jan 8, 2021

@jfy133
Copy link
Member

jfy133 commented Jan 8, 2021

@ashildv could you please manually try running Adapter removal with the instructions in the link above, where you have all your different adapters in the file, to see if it works?

I.e. adapter list of all bgi/illumina adapters. Then run with the adapter list against the bgi and illumina data respectively and see if it works?

If this works please let me know and can add adapter list as an option

@ashildv
Copy link
Contributor Author

ashildv commented Jan 8, 2021

Will do!

@apeltzer
Copy link
Member

apeltzer commented Jan 8, 2021

Perfect, sounds like the right thing to do if this works as expected 👍🏼

@jfy133 jfy133 added this to the 2.4 "Wangen" milestone Jun 4, 2021
@jfy133 jfy133 added the pending Addressed on branch waiting for related PR label Jul 18, 2021
@jfy133 jfy133 mentioned this issue Jul 26, 2021
11 tasks
@jfy133 jfy133 linked a pull request Jul 26, 2021 that will close this issue
11 tasks
@jfy133 jfy133 closed this as completed Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature good first issue Good for newcomers minor pending Addressed on branch waiting for related PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants