Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AdapterRemoval with skip 5prime trimming #226

Closed
jfy133 opened this issue Jun 25, 2019 · 3 comments
Closed

Update AdapterRemoval with skip 5prime trimming #226

jfy133 opened this issue Jun 25, 2019 · 3 comments
Milestone
V2.1 "Ravensburg"

Comments

@jfy133
Copy link
Member

jfy133 commented Jun 25, 2019 •
edited
Loading

The latest version of AdapterRemoval now has a new flag related to issues identified with erroneous trimming of 5 prime ends leading to true PCR duplicates not being removed.

We need to

a) bump the AR version in the environment
b) add the --preserve5p flag to EAGER2 options
@jfy133
Copy link
Member Author

jfy133 commented Jun 25, 2019

And thanks @maxibor for the reminder to post this ;)

@apeltzer
Copy link
Member

Yeah given that the bioconda recipe is already updated, we could probably push this in very quickly!

@apeltzer apeltzer added this to the V2.1 "Ulm" milestone Sep 16, 2019
@jfy133 jfy133 mentioned this issue Oct 19, 2019
Merged
6 tasks
@jfy133
Copy link
Member Author

jfy133 commented Oct 21, 2019

Added in #255

@jfy133 jfy133 closed this as completed Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V2.1 "Ravensburg"
Development

No branches or pull requests
2 participants
@apeltzer @jfy133