-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strategy for PR2 species assignments #593
Comments
Thanks for that info. I see annotations ending with "_sp." in PR2 v5.0.0 and v4.14.0. I could modify the assignSpecies input when using any PR2 version to not include any sequences ending with "_sp.". That would affect all versions. Let me know if you disagree. edit: that could be done by |
Sounds good! |
@jtangrot Do you agree to remove for assignSpecies all annotations ending with |
I agree, but it should be noted that I work close to Anders (andand), so my opinion is a bit biased in this case... |
Thanks, I see :) |
Would any of you like to review #599 ? Its just what we discussed here, tiny change. |
Merged, will be in next release! |
Description of feature
According to this issue in PR2 regarding assigning species, sequences with annotation ending with "_sp." may actually belong to properly named species of the same genus (but the data provider may have failed to define them at species level). If these are included when running assignSpecies one may therefor get seemingly multi-species-matching ASVs, although they in fact only match one species. It may thus be a good idea to remove reference sequences with annotation ending with "_sp." before running assignSpecies.
The text was updated successfully, but these errors were encountered: