Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update framework installations #4410

Merged
merged 2 commits into from
Dec 22, 2024
Merged

chore: update framework installations #4410

merged 2 commits into from
Dec 22, 2024

Conversation

macci001
Copy link
Contributor

@macci001 macci001 commented Dec 19, 2024

Closes ENG-1686

📝 Description

Pr updates the docs for framework installations of Next, Remix and Vite.

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • New Features
    • Added detailed documentation for integrating NextUI with Next.js, Remix, and Vite, including new commands and setup instructions.
    • Introduced a <PackageManagers> component for easier project initialization across various package managers.
  • Documentation
    • Expanded sections on Automatic Installation, Tailwind CSS setup, and Provider setup for clarity and usability.
    • Added warnings about compatibility with React versions.

Copy link

linear bot commented Dec 19, 2024

Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: bae581b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 6:17am
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 6:17am

Copy link
Contributor

coderabbitai bot commented Dec 19, 2024

Walkthrough

This pull request updates the documentation for NextUI integration across multiple frameworks (Next.js, Remix, and Vite). The changes focus on improving installation instructions, introducing a new CLI approach for project initialization, and providing comprehensive setup guidance. The documentation now includes commands for various package managers, clarifies component installation processes, and offers more detailed configuration instructions for different project structures.

Changes

File Change Summary
apps/docs/content/docs/frameworks/nextjs.mdx - Added new CLI command nextui init -t app
- Introduced <PackageManagers> component
- Updated Tailwind CSS configuration instructions
- Clarified Server Component usage
- Improved provider setup instructions
apps/docs/content/docs/frameworks/remix.mdx - Added NextUI + Remix template section
- Introduced Automatic Installation instructions
- Updated dependency installation commands
- Expanded Tailwind CSS setup guidance
- Clarified provider setup
apps/docs/content/docs/frameworks/vite.mdx - Added NextUI CLI section
- Introduced Vite template commands
- Updated dependency installation instructions
- Expanded Tailwind CSS configuration
- Added provider setup instructions

Possibly related PRs

Suggested Reviewers

  • jrgarciadev

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca36fd5 and bae581b.

📒 Files selected for processing (3)
  • apps/docs/content/docs/frameworks/nextjs.mdx (2 hunks)
  • apps/docs/content/docs/frameworks/remix.mdx (1 hunks)
  • apps/docs/content/docs/frameworks/vite.mdx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/docs/content/docs/frameworks/nextjs.mdx
🧰 Additional context used
🪛 LanguageTool
apps/docs/content/docs/frameworks/remix.mdx

[style] ~55-~55: To strengthen your wording, consider replacing the phrasal verb “leave out”.
Context: ...Block bash nextui add --all ``` If you leave out the component name, the CLI will prompt...

(OMIT_EXCLUDE)

apps/docs/content/docs/frameworks/vite.mdx

[uncategorized] ~68-~68: Possible missing comma found.
Context: ...Block bash nextui add button input ``` Or you can add the main library `@nextui-o...

(AI_HYDRA_LEO_MISSING_COMMA)


[style] ~75-~75: To strengthen your wording, consider replacing the phrasal verb “leave out”.
Context: ...Block bash nextui add --all ``` If you leave out the component name, the CLI will prompt...

(OMIT_EXCLUDE)

🔇 Additional comments (1)
apps/docs/content/docs/frameworks/remix.mdx (1)

26-26: Verify template repository accessibility

The template URL references a repository that was previously marked as TODO. Please ensure the repository is public and accessible before merging this PR.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.


<PackageManagers
commands={{
npm: 'npx create-remix@latest --template https://github.com/nextui-org/remix-template',
Copy link
Contributor Author

@macci001 macci001 Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:

  • Making the remix template public.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
apps/docs/content/docs/frameworks/nextjs.mdx (1)

Line range hint 391-391: Enhance visibility of import best practices

The crucial information about importing from individual packages (e.g., @nextui-org/button) rather than the main package is currently a note at the end of a section.

Consider moving this information to a more prominent position, such as right after the first component import example, and emphasize it with a warning blockquote:

+<Blockquote color="warning">
+**Important**: Import components from their individual packages (e.g., `@nextui-org/button`) instead of `@nextui-org/react` for better tree-shaking and smaller bundle sizes.
+</Blockquote>
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b7408c and ca36fd5.

📒 Files selected for processing (3)
  • apps/docs/content/docs/frameworks/nextjs.mdx (2 hunks)
  • apps/docs/content/docs/frameworks/remix.mdx (1 hunks)
  • apps/docs/content/docs/frameworks/vite.mdx (1 hunks)
🧰 Additional context used
🪛 LanguageTool
apps/docs/content/docs/frameworks/vite.mdx

[uncategorized] ~68-~68: Possible missing comma found.
Context: ...Block bash nextui add button input ``` Or you can add the main library `@nextui-o...

(AI_HYDRA_LEO_MISSING_COMMA)


[style] ~75-~75: To strengthen your wording, consider replacing the phrasal verb “leave out”.
Context: ...Block bash nextui add --all ``` If you leave out the component name, the CLI will prompt...

(OMIT_EXCLUDE)

apps/docs/content/docs/frameworks/remix.mdx

[style] ~55-~55: To strengthen your wording, consider replacing the phrasal verb “leave out”.
Context: ...Block bash nextui add --all ``` If you leave out the component name, the CLI will prompt...

(OMIT_EXCLUDE)

🔇 Additional comments (1)
apps/docs/content/docs/frameworks/remix.mdx (1)

26-29: ⚠️ Potential issue

Ensure the Remix template repository is publicly accessible

The template URL is being referenced in the installation commands, but there's a pending TODO about making the template public. This needs to be addressed before release to prevent a broken experience for users.

apps/docs/content/docs/frameworks/remix.mdx Show resolved Hide resolved
apps/docs/content/docs/frameworks/vite.mdx Outdated Show resolved Hide resolved
apps/docs/content/docs/frameworks/vite.mdx Show resolved Hide resolved
apps/docs/content/docs/frameworks/nextjs.mdx Show resolved Hide resolved
@jrgarciadev jrgarciadev merged commit 885c9b3 into main Dec 22, 2024
3 checks passed
@jrgarciadev jrgarciadev deleted the macci001/eng-1686 branch December 22, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📋 Scope : Docs Related to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants