Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IQtree is locked to v1.6 rather than something modern like v2.2 #7

Closed
corneliusroemer opened this issue Dec 7, 2022 · 6 comments · Fixed by #14
Closed

IQtree is locked to v1.6 rather than something modern like v2.2 #7

corneliusroemer opened this issue Dec 7, 2022 · 6 comments · Fixed by #14
Labels
bug Something isn't working

Comments

@corneliusroemer
Copy link
Member

Current Behavior

Currently both osx and linux lockfiles install IQtree v1.6.

One way we could end up with lower versions is if a package moved from conda-forge to bioconda. Then we're stuck with whatever the last version was that was in conda-forge.

@corneliusroemer corneliusroemer added the bug Something isn't working label Dec 7, 2022
@corneliusroemer
Copy link
Member Author

corneliusroemer commented Dec 7, 2022

Pinning to iqtree >=2 seems to fix it, but only seems to work when I remove pangolin and pangolearn - which we probably should not use here due to their complicated dependencies.

Users may need to install these in their separate environment. We use Nextclade in place of pangolin/pangolearn etc, so it makes sense to remove from standard environment.

@tsibley
Copy link
Member

tsibley commented Dec 7, 2022

Hmm. At the beginning of this year we explicitly added pangolin and pangolearn to our Docker runtime (and our ambient runtime install instructions). This is why they're also in our newer Conda runtime here (defined by the nextstrain-base package). I think a proposal to remove them needs more consideration than was given above.

We use Nextclade in place of pangolin/pangolearn etc

Is that a change from earlier this year?

…which we probably should not use here due to their complicated dependencies.

Their deps are pretty unfriendly to coexistence, but I'm not sure it means we shoudn't use them.

@corneliusroemer
Copy link
Member Author

IIRC, they were added before Nextclade could annotate pango lineages.

Back then, we thought it may be worth running Usher ourselves so we have up to date lineage annotations (there were some GISAID delays, and GISAID used pangoLEARN).

In the end, we never ran pangolin (Usher or pangoLEARN) in ncov-ingest.

Happy to hear feedback, whether anyone actually uses pangolin/pangoLEARN from our docker images/conda environment.

Not including Usher makes it not very practical though.

@tsibley
Copy link
Member

tsibley commented Dec 7, 2022

Our ncov workflow still nominally supports running Pangolin when the run_pangolin config flag is enabled. So I think the questions are:

  1. Are we using that? (Sounds like not.)
  2. Is anyone else using that? (Maybe CZI? Sounds like not.)

@tsibley
Copy link
Member

tsibley commented Dec 7, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants