Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map pan is broken in narratives #945

Closed
jameshadfield opened this issue Mar 13, 2020 · 3 comments · Fixed by #950
Closed

Map pan is broken in narratives #945

jameshadfield opened this issue Mar 13, 2020 · 3 comments · Fixed by #950
Labels
bug Something isn't working narratives issues / PRs relating to narrative functionality please take this issue

Comments

@jameshadfield
Copy link
Member

jameshadfield commented Mar 13, 2020 •
edited
Loading

This issue occurs in narratives, seemingly when changing between map-only display -> map+tree display. It causes the map to reposition itself incorrectly. Note that this happens after a 1000 or 1500ms delay implying that a setTimeout is involved.

Mar-13-2020 19-34-46

Steps to reproduce:

  1. Install auspice from source
  2. Obtain hCoV-19 datasets & narratives via cloning github.com/nextstrain/ncov
  3. Run auspice via auspice develop --datasetDir <ncov/auspice> --narrativeDir <ncov/narratives>

Run the latest narrative (currently unpublicised) and switch between http://localhost:4000/narratives/ncov/sit-rep/2020-03-13?n=3 and the following slide.
@jameshadfield jameshadfield added bug Something isn't working high priority please take this issue narratives issues / PRs relating to narrative functionality labels Mar 13, 2020
@cassiawag cassiawag reopened this Mar 13, 2020
@cassiawag
Copy link
Contributor

Sorry accidentally pushed a button!

@cpsandbox
Copy link
Contributor

Is it possible to get access to the data required to work on this?

@mapmeld mapmeld mentioned this issue Mar 14, 2020
Merged
@jameshadfield
Copy link
Member Author

jameshadfield commented Mar 14, 2020 •
edited
Loading

PSA: This issue now has a PR thanks to @mapmeld. For some reason I can't assign him!

@cpsandbox Is it possible to get access to the data required to work on this?

The 3 "Steps to reproduce" in the issue description should give you access to the data. Please let me know if something didn't work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working narratives issues / PRs relating to narrative functionality please take this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 945: fix jumpy narrative map
3 participants
@cpsandbox @jameshadfield @cassiawag