Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export v2: Add option to choose sample name from metadata #1264

Closed
joverlee521 opened this issue Jul 26, 2023 · 4 comments
Closed

export v2: Add option to choose sample name from metadata #1264

joverlee521 opened this issue Jul 26, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@joverlee521
Copy link
Contributor

Context

Since #1240, we support using arbitrary columns as the metadata ID column.
This column is then used as the sample name in the final output Auspice JSON.

Description

It would be nice to be able to choose a different column from the metadata to use as the sample name.
The column used as the metadata ID may not be descriptive enough to use as the sample name for display in Auspice.

Examples

We already do this in basically identical scripts for monkeypox and rsv.

@joverlee521 joverlee521 added the enhancement New feature or request label Jul 26, 2023
@jameshadfield
Copy link
Member

See nextstrain/auspice#1668 for an alternative solution

@joverlee521
Copy link
Contributor Author

@jameshadfield Ah nice! I totally missed that PR!

Then we would need to add tip_label as an allowed property for display_defaults in our auspice config schema.

I also think export v2 should verify the tip_label field is an available node_attr or automatically add it as a node_attr if the field is available in the metadata file.

@jameshadfield
Copy link
Member

Great suggestions -- I think that Auspice PR needs more testing & feedback before we use it, but I think it's ultimately a better direction than swapping back in the strain name (as monkeypox + rsv do) because of how duplicate node names are handled in Auspice.

@joverlee521
Copy link
Contributor Author

Closing since the alternative solution in Auspice has been released.

@joverlee521 joverlee521 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants