Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svg files are failing #6

Closed
skjnldsv opened this issue Feb 26, 2019 · 6 comments
Closed

Svg files are failing #6

skjnldsv opened this issue Feb 26, 2019 · 6 comments
Labels
3. to review Waiting for reviews enhancement New feature or request

Comments

@skjnldsv
Copy link
Member

What to do with tiny images? e.g. 16x16 px
@skjnldsv skjnldsv added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of labels Feb 26, 2019
@rullzer
Copy link
Member

rullzer commented Feb 27, 2019

SVG so just scale them up. should still look awesome 😜

@skjnldsv
Copy link
Member Author

@rullzer yes, but to what extend? :)
The maximum?

@rullzer
Copy link
Member

rullzer commented Feb 27, 2019

By default sure... then at least it fills the viewport properly...

@skjnldsv
Copy link
Member Author

Svg support is in, but to quote myself: 🤷‍♂️ 😕

skjnldsv> accessing svg through the remote.php return text/plain
skjnldsv> and not image/svg+xml
skjnldsv> therefore failing on tags

@skjnldsv skjnldsv changed the title Svg support Svg files are failing Feb 28, 2019
@rullzer
Copy link
Member

rullzer commented Mar 1, 2019

Yes. This is because of potential xss attacks with SVG. So they are served at text/plain

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 1, 2019

@rullzer I'll see what I can do

@skjnldsv skjnldsv mentioned this issue Mar 1, 2019
Merged
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rullzer @skjnldsv