Alphabetic sorting in Viewer is wrong with numbers

[jancborchardt]

Related to Slideshow viewer not adapting sorting mode of files app #366 but different.

If you have these Files:

• 1.jpg
• 2.jpg
• …
• 9.jpg
• 10.jpg
• 11.jpg

And then you open 1.jpg to start going through them, the Viewer will show them in this order:

• 1.jpg
• 10.jpg
• 11.jpg
• 2.jpg
• …
• 9.jpg

Of course it should be the same order as in Files, the "human" order to sort numbers. ;)

@skjnldsv if you point out where this would have to be changed, this could be a good first issue?

[skjnldsv]

viewer/src/views/Viewer.vue

Lines 365 to 367 in 8eafdca

	// https://github.com/nextcloud/server/blob/a83b79c5f8ab20ed9b4d751167417a65fa3c42b8/apps/files/lib/Controller/ApiController.php#L247
	this.fileList = filteredFiles.sort((a, b) => sortCompare(a, b, 'basename'))

[skjnldsv]

viewer/src/utils/fileUtils.js

Lines 64 to 88 in 8eafdca

	const sortCompare = function(fileInfo1, fileInfo2, key, asc = true) {
	if (fileInfo1.isFavorite && !fileInfo2.isFavorite) {
	return -1
	} else if (!fileInfo1.isFavorite && fileInfo2.isFavorite) {
	return 1
	}
	// if this is a number, let's sort by integer
	if (isNumber(fileInfo1[key]) && isNumber(fileInfo2[key])) {
	return Number(fileInfo1[key]) - Number(fileInfo2[key])
	}
	// else we sort by string, so let's sort directories first
	if (fileInfo1.type === 'directory' && fileInfo2.type !== 'directory') {
	return -1
	} else if (fileInfo1.type !== 'directory' && fileInfo2.type === 'directory') {
	return 1
	}
	// finally sort by name
	return asc
	? fileInfo1[key].localeCompare(fileInfo2[key], OC.getLanguage())
	: -fileInfo1[key].localeCompare(fileInfo2[key], OC.getLanguage())
	}

[skjnldsv]

Related nextcloud/server#13661

[florianwgnr]

Just experienced this issue - is there any update on it?

My files are ordered like this:

• Image 01.jpg
• Image 02.jpg
• ...

The viewer displays them in the wrong order:

1. Image 01.jpg
2. Image 010.jpg
3. Image 011.jpg
4. ...