Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf: generate and ship authoritative Composer class loader #1535

Closed
ChristophWurst opened this issue Jan 30, 2023 · 1 comment · Fixed by #1544
Closed

Perf: generate and ship authoritative Composer class loader #1535

ChristophWurst opened this issue Jan 30, 2023 · 1 comment · Fixed by #1544
Assignees
Labels
3. to review Waiting for reviews enhancement New feature or request

Comments

@ChristophWurst
Copy link
Member

Is your feature request related to a problem? Please describe.

This app does not ship its own classloader, so the non-optimized fallback loader is used.

Describe the solution you'd like

https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/classloader.html#replacing-nextcloud-s-autoloader

Describe alternatives you've considered

N/a

Additional context

composer.json has already been configured for an optimized class loader, but

  • The vendor/autoload.php vendor/composer/* files are missing in the release
  • There is no PSR-4 mapping for this app's own class files
@ChristophWurst ChristophWurst added enhancement New feature or request 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jan 30, 2023
@ChristophWurst ChristophWurst changed the title Perf: generate and ship authoratative Composer class loader Perf: generate and ship authoritative Composer class loader Jan 30, 2023
@miaulalala miaulalala self-assigned this Feb 9, 2023
@miaulalala
Copy link
Contributor

#1544

@miaulalala miaulalala added 3. to review Waiting for reviews and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants