Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart picker can't set links for selected section of text / workflow for linking to resources #4783

Closed
tatrapikao opened this issue Sep 7, 2023 · 4 comments · Fixed by #5832
Assignees
Labels
bug Something isn't working

Comments

@tatrapikao
Copy link

tatrapikao commented Sep 7, 2023

Describe the bug
If i mark a section of text i can set a link to a website whilst i can not do the same thing when i set a Link to a different Collectives Page via the Smartpicker. In that case the sected text is replaced by the string of the actual Link.

Expected behavior
I think the desirable behaviour for all tree kinds of linking(File/Website/Smart-Picker) would be dependent on the state of the text courser: If text is selected -> add the resource as a link to the selected section of text, if nothing is selected add the URL to the position of the courser, If nothing is selected and the courser is in an empty line with a line brake at the end and an empty line after it, or no line after it at all, a preview or if possible the resource itself should be rendered.

Client details:

  • Browser: [firefox]
  • Version: [116.0.2 (64-Bit)]
  • Device: [desktop]

Collectives app version: (2.7.0)

@tatrapikao tatrapikao added the bug Something isn't working label Sep 7, 2023
@juliusknorr
Copy link
Member

I'll move this to the text app repo since this seems to be a general bug in the editor.

@juliusknorr juliusknorr transferred this issue from nextcloud/collectives Sep 7, 2023
@juliusknorr juliusknorr moved this to 📄 To do (~10 entries) in 📝 Office team Jan 26, 2024
@JonasTrampe
Copy link

Is there any progress?

@enjeck
Copy link
Contributor

enjeck commented Apr 2, 2024

@tatrapikao Sorry, I'm struggling to understand the problem here. If possible, please share an image or video?.

@tatrapikao
Copy link
Author

EvQGKrem1x

@enjeck enjeck moved this from 📄 To do (~10 entries) to 👀 In review in 📝 Office team May 27, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Office team May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants