From c318e849103004d9c64ea91c98628f5dc9a702aa Mon Sep 17 00:00:00 2001 From: Florian Steffens Date: Thu, 10 Aug 2023 07:53:31 +0200 Subject: [PATCH] fix unit tests Signed-off-by: Florian Steffens --- tests/unit/Service/PermissionsServiceTest.php | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tests/unit/Service/PermissionsServiceTest.php b/tests/unit/Service/PermissionsServiceTest.php index 34dc78528..f4dcd06a6 100644 --- a/tests/unit/Service/PermissionsServiceTest.php +++ b/tests/unit/Service/PermissionsServiceTest.php @@ -28,6 +28,7 @@ use OCA\Tables\Db\ShareMapper; use OCA\Tables\Db\TableMapper; +use OCA\Tables\Db\ViewMapper; use OCA\Tables\Errors\InternalError; use OCA\Tables\Helper\UserHelper; use Psr\Log\LoggerInterface; @@ -39,8 +40,9 @@ public function testPreCheckUserIdGivenUser() { $userId = "TestUser"; $tableMapper = $this->createMock(TableMapper::class); $shareMapper = $this->createMock(ShareMapper::class); + $viewMapper = $this->createMock(ViewMapper::class); $userHelper = $this->createMock(UserHelper::class); - $permissionsService = new PermissionsService($logger, $userId, $tableMapper, $shareMapper, $userHelper, false); + $permissionsService = new PermissionsService($logger, $userId, $tableMapper, $viewMapper, $shareMapper, $userHelper, false); self::assertEquals($userId, $permissionsService->preCheckUserId($userId)); } @@ -49,9 +51,10 @@ public function testPreCheckUserIdNoUser() { $logger = $this->createMock(LoggerInterface::class); $userId = null; $tableMapper = $this->createMock(TableMapper::class); + $viewMapper = $this->createMock(ViewMapper::class); $shareMapper = $this->createMock(ShareMapper::class); $userHelper = $this->createMock(UserHelper::class); - $permissionsService = new PermissionsService($logger, $userId, $tableMapper, $shareMapper, $userHelper, false); + $permissionsService = new PermissionsService($logger, $userId, $tableMapper, $viewMapper, $shareMapper, $userHelper, false); self::expectException(InternalError::class); $permissionsService->preCheckUserId($userId); @@ -61,9 +64,10 @@ public function testPreCheckUserIdNoUserButContext() { $logger = $this->createMock(LoggerInterface::class); $userId = 'john'; $tableMapper = $this->createMock(TableMapper::class); + $viewMapper = $this->createMock(ViewMapper::class); $shareMapper = $this->createMock(ShareMapper::class); $userHelper = $this->createMock(UserHelper::class); - $permissionsService = new PermissionsService($logger, $userId, $tableMapper, $shareMapper, $userHelper, false); + $permissionsService = new PermissionsService($logger, $userId, $tableMapper, $viewMapper, $shareMapper, $userHelper, false); self::assertEquals($userId, $permissionsService->preCheckUserId(null)); } @@ -72,9 +76,10 @@ public function testPreCheckUserIdNoUserNotAllowed() { $logger = $this->createMock(LoggerInterface::class); $userId = ''; $tableMapper = $this->createMock(TableMapper::class); + $viewMapper = $this->createMock(ViewMapper::class); $shareMapper = $this->createMock(ShareMapper::class); $userHelper = $this->createMock(UserHelper::class); - $permissionsService = new PermissionsService($logger, $userId, $tableMapper, $shareMapper, $userHelper, false); + $permissionsService = new PermissionsService($logger, $userId, $tableMapper, $viewMapper, $shareMapper, $userHelper, false); self::expectException(InternalError::class); $permissionsService->preCheckUserId($userId, false); @@ -87,9 +92,10 @@ public function testPreCheckUserIdNoUserAllowed() { $logger = $this->createMock(LoggerInterface::class); $userId = ''; $tableMapper = $this->createMock(TableMapper::class); + $viewMapper = $this->createMock(ViewMapper::class); $shareMapper = $this->createMock(ShareMapper::class); $userHelper = $this->createMock(UserHelper::class); - $permissionsService = new PermissionsService($logger, $userId, $tableMapper, $shareMapper, $userHelper, true); + $permissionsService = new PermissionsService($logger, $userId, $tableMapper, $viewMapper, $shareMapper, $userHelper, true); self::assertEquals($userId, $permissionsService->preCheckUserId($userId)); }