From ce52cfb857fc7741d665ce07c1bb633d615be4ce Mon Sep 17 00:00:00 2001
From: Joas Schilling <coding@schilljs.com>
Date: Fri, 15 Jul 2022 09:26:28 +0200
Subject: [PATCH] Fix HTML validation of material design icons

Signed-off-by: Joas Schilling <coding@schilljs.com>
---
 .../ConversationPermissionsSettings.vue       |  4 +---
 .../LinkShareSettings.vue                     |  8 ++------
 .../NotificationsSettings.vue                 | 18 +++--------------
 .../DeviceChecker/DeviceChecker.vue           |  8 ++------
 .../MessagesGroup/Message/Message.vue         | 14 +++----------
 src/components/MessagesList/MessagesList.vue  |  4 +---
 .../AudioRecorder/AudioRecorder.vue           |  4 +---
 .../NewMessageForm/NewMessageForm.vue         |  8 ++------
 .../Participant/Participant.vue               | 20 +++++--------------
 9 files changed, 20 insertions(+), 68 deletions(-)

diff --git a/src/components/ConversationSettings/ConversationPermissionsSettings.vue b/src/components/ConversationSettings/ConversationPermissionsSettings.vue
index f10fdaf2472..aa45c33ba1e 100644
--- a/src/components/ConversationSettings/ConversationPermissionsSettings.vue
+++ b/src/components/ConversationSettings/ConversationPermissionsSettings.vue
@@ -70,9 +70,7 @@
 				:aria-label="t('spreed', 'Edit permissions')"
 				class="nc-button nc-button__main"
 				@click="showPermissionsEditor = true">
-				<Pencil :size="20"
-					decorative
-					title="" />
+				<Pencil :size="20" />
 			</button>
 		</div>
 		<PermissionEditor v-if="showPermissionsEditor"
diff --git a/src/components/ConversationSettings/LinkShareSettings.vue b/src/components/ConversationSettings/LinkShareSettings.vue
index 14706ed416b..46c3bb9595a 100644
--- a/src/components/ConversationSettings/LinkShareSettings.vue
+++ b/src/components/ConversationSettings/LinkShareSettings.vue
@@ -81,18 +81,14 @@
 		<div class="app-settings-subsection">
 			<button ref="copyLinkButton"
 				@click.prevent="handleCopyLink">
-				<ClipboardTextOutline :size="16"
-					decorative
-					title="" />
+				<ClipboardTextOutline :size="16" />
 				{{ t('spreed', 'Copy conversation link') }}
 			</button>
 		</div>
 		<div v-if="isSharedPublicly" class="app-settings-subsection">
 			<button :disabled="isSendingInvitations"
 				@click.prevent="handleResendInvitations">
-				<Email :size="16"
-					decorative
-					title="" />
+				<Email :size="16" />
 				{{ t('spreed', 'Resend invitations') }}
 			</button>
 			<span v-if="isSendingInvitations" class="icon-loading-small spinner" />
diff --git a/src/components/ConversationSettings/NotificationsSettings.vue b/src/components/ConversationSettings/NotificationsSettings.vue
index 2af6da5c367..e7609e332f7 100644
--- a/src/components/ConversationSettings/NotificationsSettings.vue
+++ b/src/components/ConversationSettings/NotificationsSettings.vue
@@ -26,51 +26,39 @@
 			class="radio-element"
 			:class="{'radio-element--active': isNotifyAlways}"
 			@click.prevent.exact="setNotificationLevel(1)">
-			<VolumeHigh decorative
-				title=""
-				:size="20"
+			<VolumeHigh :size="20"
 				class="radio-element__icon" />
 			<label class="radio-element__label">
 				{{ t('spreed', 'All messages') }}
 			</label>
 			<Check v-if="isNotifyAlways"
 				class="check"
-				decorative
-				title=""
 				:size="20" />
 		</a>
 		<a href="#"
 			class="radio-element"
 			:class="{'radio-element--active': isNotifyMention}"
 			@click.prevent.exact="setNotificationLevel(2)">
-			<Account decorative
-				title=""
-				:size="20"
+			<Account :size="20"
 				class="radio-element__icon" />
 			<label class="radio-element__label">
 				{{ t('spreed', '@-mentions only') }}
 			</label>
 			<Check v-if="isNotifyMention"
 				class="check"
-				decorative
-				title=""
 				:size="20" />
 		</a>
 		<a href="#"
 			class="radio-element"
 			:class="{'radio-element--active': isNotifyNever}"
 			@click.prevent.exact="setNotificationLevel(3)">
-			<VolumeOff decorative
-				title=""
-				:size="20"
+			<VolumeOff :size="20"
 				class="radio-element__icon" />
 			<label class="radio-element__label">
 				{{ t('spreed', 'Off') }}
 			</label>
 			<Check v-if="isNotifyNever"
 				class="check"
-				decorative
-				title=""
 				:size="20" />
 		</a>
 
diff --git a/src/components/DeviceChecker/DeviceChecker.vue b/src/components/DeviceChecker/DeviceChecker.vue
index 94b681bcc77..4bf55a4fa38 100644
--- a/src/components/DeviceChecker/DeviceChecker.vue
+++ b/src/components/DeviceChecker/DeviceChecker.vue
@@ -145,9 +145,7 @@
 							@click="silentCall= true">
 							{{ t('spreed', 'The conversation participants will not be notified about this call') }}
 							<BellOff slot="icon"
-								:size="16"
-								decorative
-								title="" />
+								:size="16" />
 						</ActionButton>
 					</template>
 					<template v-else>
@@ -157,9 +155,7 @@
 							@click="silentCall= false">
 							{{ t('spreed', 'The conversation participants will be notified about this call') }}
 							<Bell slot="icon"
-								:size="16"
-								decorative
-								title="" />
+								:size="16" />
 						</ActionButton>
 					</template>
 				</Actions>
diff --git a/src/components/MessagesList/MessagesGroup/Message/Message.vue b/src/components/MessagesList/MessagesGroup/Message/Message.vue
index 46c94abef7a..d9e46070a96 100644
--- a/src/components/MessagesList/MessagesGroup/Message/Message.vue
+++ b/src/components/MessagesList/MessagesGroup/Message/Message.vue
@@ -84,14 +84,10 @@ the main body of the message as well as a quote.
 							:aria-label="sendingErrorIconTooltip"
 							@click="handleRetry">
 							<template #icon>
-								<Reload decorative
-									title=""
-									:size="16" />
+								<Reload :size="16" />
 							</template>
 						</Button>
 						<AlertCircle v-else
-							decorative
-							title=""
 							:size="16" />
 					</div>
 					<div v-else-if="isTemporary && !isTemporaryUpload || isDeleting"
@@ -102,17 +98,13 @@ the main body of the message as well as a quote.
 						v-tooltip.auto="commonReadIconTooltip"
 						class="message-status"
 						:aria-label="commonReadIconTooltip">
-						<CheckAll decorative
-							title=""
-							:size="16" />
+						<CheckAll :size="16" />
 					</div>
 					<div v-else-if="showSentIcon"
 						v-tooltip.auto="sentIconTooltip"
 						class="message-status"
 						:aria-label="sentIconTooltip">
-						<Check decorative
-							title=""
-							:size="16" />
+						<Check :size="16" />
 					</div>
 				</div>
 			</div>
diff --git a/src/components/MessagesList/MessagesList.vue b/src/components/MessagesList/MessagesList.vue
index c48c03b5635..5c56d034713 100644
--- a/src/components/MessagesList/MessagesList.vue
+++ b/src/components/MessagesList/MessagesList.vue
@@ -55,9 +55,7 @@ get the messagesList array and loop through the list to generate the messages.
 				class="scroll-to-bottom"
 				@click="smoothScrollToBottom">
 				<template #icon>
-					<ChevronDown decorative
-						title=""
-						:size="20" />
+					<ChevronDown :size="20" />
 				</template>
 			</Button>
 		</transition>
diff --git a/src/components/NewMessageForm/AudioRecorder/AudioRecorder.vue b/src/components/NewMessageForm/AudioRecorder/AudioRecorder.vue
index 01977880d9e..4d1d127ba6b 100644
--- a/src/components/NewMessageForm/AudioRecorder/AudioRecorder.vue
+++ b/src/components/NewMessageForm/AudioRecorder/AudioRecorder.vue
@@ -60,9 +60,7 @@
 				:class="{'audio-recorder__trigger--recording': isRecording}"
 				@click="stop">
 				<template #icon>
-					<Check :size="16"
-						title=""
-						decorative />
+					<Check :size="16" />
 				</template>
 			</Button>
 		</div>
diff --git a/src/components/NewMessageForm/NewMessageForm.vue b/src/components/NewMessageForm/NewMessageForm.vue
index 9b27799b226..b349b889004 100644
--- a/src/components/NewMessageForm/NewMessageForm.vue
+++ b/src/components/NewMessageForm/NewMessageForm.vue
@@ -114,9 +114,7 @@
 							@click.prevent="handleSubmit({ silent: true })">
 							{{ silentSendInfo }}
 							<BellOff slot="icon"
-								:size="16"
-								decorative
-								title="" />
+								:size="16" />
 						</ActionButton>
 					</Actions>
 					<!-- Send -->
@@ -127,9 +125,7 @@
 						:aria-label="t('spreed', 'Send message')"
 						@click.prevent="handleSubmit({ silent: false })">
 						<template #icon>
-							<Send title=""
-								:size="16"
-								decorative />
+							<Send :size="16" />
 						</template>
 					</Button>
 				</template>
diff --git a/src/components/RightSidebar/Participants/ParticipantsList/Participant/Participant.vue b/src/components/RightSidebar/Participants/ParticipantsList/Participant/Participant.vue
index 463fdb023f2..8a8673e095c 100644
--- a/src/components/RightSidebar/Participants/ParticipantsList/Participant/Participant.vue
+++ b/src/components/RightSidebar/Participants/ParticipantsList/Participant/Participant.vue
@@ -133,36 +133,28 @@
 					:close-after-click="true"
 					@click="applyDefaultPermissions">
 					<template #icon>
-						<LockReset :size="20"
-							title=""
-							decorative />
+						<LockReset :size="20" />
 					</template>
 					{{ t('spreed', 'Reset custom permissions') }}
 				</ActionButton>
 				<ActionButton :close-after-click="true"
 					@click="grantAllPermissions">
 					<template #icon>
-						<LockOpenVariant :size="20"
-							title=""
-							decorative />
+						<LockOpenVariant :size="20" />
 					</template>
 					{{ t('spreed', 'Grant all permissions') }}
 				</ActionButton>
 				<ActionButton :close-after-click="true"
 					@click="removeAllPermissions">
 					<template #icon>
-						<Lock :size="20"
-							title=""
-							decorative />
+						<Lock :size="20" />
 					</template>
 					{{ t('spreed', 'Remove all permissions') }}
 				</ActionButton>
 				<ActionButton :close-after-click="true"
 					@click="showPermissionsEditor">
 					<template #icon>
-						<Pencil :size="20"
-							title=""
-							decorative />
+						<Pencil :size="20" />
 					</template>
 					{{ t('spreed', 'Edit permissions') }}
 				</ActionButton>
@@ -177,9 +169,7 @@
 				:close-after-click="true"
 				@click="sendCallNotification">
 				<template #icon>
-					<Bell :size="20"
-						title=""
-						decorative />
+					<Bell :size="20" />
 				</template>
 				{{ t('spreed', 'Send call notification') }}
 			</ActionButton>