Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ–ΌοΈ Conversation avatars #927

Closed
7 of 11 tasks
jancborchardt opened this issue May 30, 2018 · 18 comments Β· Fixed by #8333
Closed
7 of 11 tasks

πŸ–ΌοΈ Conversation avatars #927

jancborchardt opened this issue May 30, 2018 · 18 comments Β· Fixed by #8333

Comments

@jancborchardt
Copy link
Member

jancborchardt commented May 30, 2018

Update as per last discussions:

  • Cropper like in user avatar
  • Automatic shrinking
  • Transparency => white background
  • Animation not allowed
  • One endpoint to rule them all πŸ’ : user avatar, file mimetype-icon, conversation-image****

Not available for one-to-one, file-conversations and video-verification
No mashing of user avatars as they would need updating and tracking when a user changes their avatar


Work packages

@nickvergessen

This comment has been minimized.

@nickvergessen

This comment has been minimized.

@nickvergessen

This comment has been minimized.

@Tachi107
Copy link
Contributor

  • No mashing of user avatars as they would need updating and tracking when a user changes their avatar

Can't the refetch be done manually? Like an option in the conversation settings to update the group picture

@marcoambrosini marcoambrosini self-assigned this Nov 26, 2020
@marcoambrosini marcoambrosini changed the title Group picture (or placeholder with mix of participant avatars) Group conversation picture Nov 26, 2020
@nickvergessen
Copy link
Member

Can't the refetch be done manually? Like an option in the conversation settings to update the group picture

Well, then when a user changes their avatar they need to ask all moderators to update it and so on.

@Tachi107
Copy link
Contributor

Can't the refetch be done manually? Like an option in the conversation settings to update the group picture

Well, then when a user changes their avatar they need to ask all moderators to update it and so on.

Yeah, that could be a problem in big conversations, but at the same time I see the mashing of user avatars as something that would be primarily used in small groups, like a chat of ten friends, and asking a friend to push a button doesn't sound like a big issue

@nickvergessen
Copy link
Member

Yeah, that could be a problem in big conversations, but at the same time I see the mashing of user avatars as something that would be primarily used in small groups, like a chat of ten friends, and asking a friend to push a button doesn't sound like a big issue

yeah, but since we always have to consider all Nextcloud installations, from 1 person to big companies, we will do what all bigger messengers do: No mash-up but just the current default icon.

@Tachi107
Copy link
Contributor

Mh, okay, still better than not having the possibility to set a group picture at all :)

@nickvergessen
Copy link
Member

API Specs

  • We need OCS API, suggestion: /api/{apiVersion}/room/{token}/image - Similar to https://github.com/nextcloud/spreed/blob/master/lib/Controller/TempAvatarController.php
    • POST a new image
      • Needs to validate the file is an image
      • Needs to validate the image is a square and of a supported type (check User avatar code for what we should allow)
      • File should be stored with OCP\Files\IAppData with conversation token + file type as name
    • DELETE to remove an image
    • GET which serves the image as FileDisplayResponse
      • Not sure if that works as OCSController, if it does not we need another Controller with another route.
      • If AppData does not have a file with the conversation name, we fall back to returning an icon based on the conversation type
      • If the conversation is a one-to-one conversation we fall back to the user avatar?

@nickvergessen nickvergessen changed the title Group conversation picture πŸ–ΌοΈ Conversation avatar Nov 10, 2022
@nickvergessen nickvergessen changed the title πŸ–ΌοΈ Conversation avatar πŸ–ΌοΈ Conversation avatars Nov 10, 2022
@nickvergessen nickvergessen added medium and removed low labels Nov 10, 2022
@e-caste
Copy link

e-caste commented Nov 10, 2022

2 cool frontend features that I don't see mentioned above and that I think could be useful:

  1. Telegram allows to "Search Web" when setting a group picture (e.g. I want to set it to a picture of a horse but I don't have one ready, I can just skip the step of downloading it locally and then setting it from my gallery)
  2. Whatsapp also allows to set an "Emoji & Sticker". For a quick group chat creation process I think that could be a very nice UX addition and probably wouldn't be too hard to implement (last famous words?) in the sense that the user can spawn an emoji picker and choose from those. Maybe a nice improvement over using the rendered emojis, since they're low resolution, would be to use a high resolution emoji pack such as https://twemoji.twitter.com which also contains SVG versions. This is similar to the workaround @nickvergessen is using (setting emojis in the chat titles), but would be an official implementation.

@nickvergessen
Copy link
Member

Reopening meta ticket until the dedicated issues got resolved

@nickvergessen nickvergessen reopened this Dec 7, 2022
@nickvergessen
Copy link
Member

@e-caste for 1. I can say that we are not going to add this because it creates security issues on the way.
2. sounds like a good/funny follow up idea, but it will not be part of the initial feature. Can you create a new ticket?

@Kitanit
Copy link

Kitanit commented May 8, 2023

As I understand it will not work in NC 26, only 27+ ?

@nickvergessen
Copy link
Member

Yes, but 27 is just around the corner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment