Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The shortcuts use the control (^) button on macOS instead of the command (⌘) button #13654

Closed
e-caste opened this issue Jul 29, 2023 · 5 comments

Comments

@e-caste
Copy link

e-caste commented Jul 29, 2023

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Click on settings in the bottom left
  2. Shortcuts show that the used modifier button is control
  3. I tried it and it actually uses control instead of command

Expected behaviour

Normally shortcuts on macOS should use command as the modifier button, while control is mostly used in the terminal or to trigger very specific shortcuts.

Actual behaviour

Shortcuts use the control button as the modifier.

Desktop client

Talk Desktop client version: v0.9.0

Operating system: macOS

Operating system version: Ventura 13.4.1 (c)

Microphone available: yes

Camera available: no

Server

Nextcloud version: (see status page: /status.php) 27.0.1

Talk app version: (see apps admin page: /index.php/settings/apps) 17.0.1

Custom Signaling server configured: yes/no and version (see additional admin settings: /index.php/index.php/settings/admin/talk#signaling_server) yes

Custom TURN server configured: yes/no (see additional admin settings: /index.php/settings/admin/talk#turn_server) yes

Custom STUN server configured: yes/no (see additional admin settings: /index.php/settings/admin/talk#stun_server) yes

Logs

Client log

Insert your browser log here, this could for example include:
a) The javascript console log
b) The network log
c) ...
@ShGKme
Copy link
Contributor

ShGKme commented Jul 29, 2023

Do you mean these settings?
image

@e-caste
Copy link
Author

e-caste commented Jul 29, 2023

@ShGKme Yes, exactly. For now only Ctrl+F should be converted to Cmd+F. In the future the number of keyboard shortcuts may grow, and for this I believe being consistent with the OS's defaults should be done starting from v1.0.0.

@ShGKme
Copy link
Contributor

ShGKme commented Jul 29, 2023

@ShGKme Yes, exactly. For now only Ctrl+F should be converted to Cmd+F. In the future the number of keyboard shortcuts may grow, and for this I believe being consistent with the OS's defaults should be done starting from v1.0.0.

Thank you for the bug report.

After the report I have also found that this hotkey doesn't proper for in Web at all 🥲

@ER-EPR
Copy link

ER-EPR commented May 14, 2024

Hi, can I ask when will the next preview be released? I really need it, for the blinking icon feature.

@ShGKme ShGKme self-assigned this Oct 28, 2024
@ShGKme ShGKme transferred this issue from nextcloud/talk-desktop Oct 28, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Oct 29, 2024

@ShGKme ShGKme closed this as completed Oct 29, 2024
@ShGKme ShGKme removed their assignment Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants