Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gray-out relevant configuration options when config_is_read_only is set #8960

Closed
Tsuroerusu opened this issue Mar 23, 2018 · 2 comments
Closed

Comments

@Tsuroerusu
Copy link

I run a server that hosts Nextcloud instances for my customers, and as the server admin, I enforce various settings such as SMTP settings, trashbin retention etc. Because of that, I have a read-only configuration file, so that the SMTP settings cannot be changed and so on.

I just noticed that when 'config_is_read_only' is enabled, what happens right now is that the options in the Settings appear as they would with a writeable configuration, and if one tries to change them it just hangs at "Saving...". That might confuse users into thinking they did something wrong or something is not working.

I would like to propose that either when either 'config_is_read_only' or a secondary option related to it is set, the options in the Settings that now cannot be altered through the web UI be grayed out. This would be similar to how Nextcloud grays out PHP-related settings that are not alterable through the web UI, for example the maximum upload size listed under "Additional settings".

Steps to reproduce

  1. Set 'config_is_read_only' in config.php
  2. Look through the web UI and try to change settings that are stored in config.php
  3. Notice how it just stays at "Saving...".

Expected behaviour

The settings that cannot be changed after setting the 'config_is_read_only' option should be grayed out similarly to how settings that relate to PHP or the server in general are grayed out of the relevant configuration files are not writeable.

Actual behaviour

The settings appear alterable, and one can actually try to edit them, but when it then tries to save the change it just says "Saving..." in red, and nothing happens as far as the user is concerned.

@MorrisJobke
Copy link
Member

Those are the related settings:

  • email settings
  • updater channel
  • log level

@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jul 19, 2018
@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Jun 12, 2019
@ghost ghost removed the stale Ticket or PR with no recent activity label Jun 12, 2019
@szaimen
Copy link
Contributor

szaimen commented May 21, 2021

I am going to close this since there doesn't seem to be a lot of interest (no upvotes) and no respond since around 2 years. Please reopen if you still want to implement this.

@szaimen szaimen closed this as completed May 21, 2021
@szaimen szaimen added Nice to have and removed 1. to develop Accepted and waiting to be taken care of labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants