Don't tell me if my federated share user has a locked file

[enoch85]

12.0.3 and all that... Let me know if I need to post a full configuration report.

As I share the NC VM from my own Server using Nextcloud there are also users that chose to accept the share as a federated share. Every time I upload a new version, they sync with their clients. Up until now I've been wondering why the heck I get so many errors about that the file is locked, litterlay hundreds, maybe thousands per day - until it hit me, my federated share users...

So this is how it looks like:

So, please stop informing me that my users files are locked, at least put it in info or debug. Because I mean, the file is locked on their server, not mine right?

Either way, I don't think locking is an error, rather a feature. So showing it in error is not needed IMHO.

[MorrisJobke]

cc @icewind1991 @nextcloud/sharing

[rullzer]

This is not how federation works. Federation isn't syncing.

A bit abstraced away it basically works as:

• userA on cloudA shares a folderX to userB on cloudB
• userB accepts
• userB wants to download a fileY from folderX
• fileY is locked on cloudB
• connection to cloudA is established
• fileY is locked on cloudA
• fileY is streamed to cloudB which streams it to userB
• once done all the locks are released

So yes the file is locked on your instance.
And the reason it shows up is because it prevents you from properly syncing. If you want to write to filerY etc.

[enoch85]

@rullzer Thanks for the clarification. So you mean that you can't download one file at the same time by multiple users, even if the file isn't changed?

In my case I don't touch that file or try to sync it except when I do a new release. It just lays there in the same folder, with the same checksum and all that. So to me it seems impossible that it would produce any locking errors. That is if the sync client isn't living it's on life and make decisions by itself?

I've heard many (around 5) users that said that they had "issues" with locked files. I think it's a good feature but in some cases it's just a PIA. I mean my owncube mirror in Australia won't sync because the README.txt is locked, and has been for 4 days now. It should be released at least every cron run, but in that specific case it won't just work.

My solution to the issue has been in the past that I closed the client, removed all the sync logs and csync etc, en then started the client again to get a clean sync. That's not optimal though as you I'm sure you agree on.

And then again, what's your opinion on putting these messages as info or debug instead?

[rullzer]

No downloading should work fine. As it just does a read lock.

[enoch85]

So, why is the file locked if I don't touch it? Does a lock happen if the sync client do a sync check (like it does every now and then) at the same time as someone tries to download it?

And then again, what's your opinion on putting these messages as info or debug instead?

[rullzer]

Message should probabaly stay as it is. As it should not happen if only everybody reads.

Yet I don't know why it shows up then.

@icewind1991 any clue?

[enoch85]

@rullzer @MorrisJobke Milestone 14?

[enoch85]

@rullzer Please take a look in #8723. They talk about Redis there. Is there any way to fix it in the code?

[enoch85]

And BTW, my AUS mirror has still locked files and had so since one year now. Everytime I try to delete a file that is shared, it's locked. For every new release I have to make a new folder and then share that.

Since I don't have shell access I can't fix it manually, and cron should take care of it, but doesn't.

[szaimen]

I'm closing this issue due to inactivity. If this is still happening please make sure to upgrade to the latest version. After that, feel free to reopen.

[enoch85]

@szaimen are you in "cleaning up issues mode" today? 😄

[szaimen]

@szaimen are you in "cleaning up issues mode" today? 😄

yes :)