Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: User group list and external storage share dropdown sorting is based on outdated name (Incomplete group rename) #43233

Open
5 of 8 tasks
Zomtir opened this issue Jan 31, 2024 · 2 comments
Labels

Comments

@Zomtir
Copy link

Zomtir commented Jan 31, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

After renaming a user group, some lists will not update (sort) to the updated group name.

Affected modules:

  • User administration panel: The user group list (left menu bar)
  • External storage: The share dropdown lists (group shares suggestions)

NOT affected:

  • User administration panel: User group membership (group suggestions)

As mentioned this problem is not present in all interfaces. A also checked the database layouts and the initial name upon creating a group is persisting in some columns even after the group was renamed. I suggest that database columns that contain duplicated information might be able to be refactored / merged / cleaned up to prevent such issues in the first place. Different interfaces seem to pull the group name information from different database columns while the rename function does not update all columns.

Steps to reproduce

  1. Create a user group "Daniel"
  2. Create a user group "Bob". "Bob" will be inserted before "Daniel". Current order is "Bob, Daniel".
  3. Create a user group "Casper". "Casper" will be inserted before "Daniel". Current order is "Bob, Casper, Daniel".
  4. Rename "Casper" to "Alice". "Casper/Alice" will not change position. Current order is "Bob, Alice, Daniel".

Expected behavior

  1. Create a user group "Daniel"
  2. Create a user group "Bob". "Bob" will be inserted before "Daniel". Current order is "Bob, Daniel".
  3. Create a user group "Casper". "Casper" will be inserted before "Daniel". Current order is "Bob, Casper, Daniel".
  4. Rename "Casper" to "Alice". "Casper/Alice" will change position. Current order is "Alice, Bob, Daniel".

Installation method

Community Manual installation with Archive

Nextcloud Server version

28

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

None

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@Zomtir Zomtir added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jan 31, 2024
@joshtrichards
Copy link
Member

I thought the sorting wasn't alphabetical until recently - i.e. see #44465

@Zomtir
Copy link
Author

Zomtir commented Aug 1, 2024

The sorting was done by group size in the user panel, but also only at 2 out of 3 locations:

Nextcloud Group Sorting (User panel)

The sorting in the external storage selector panel is arbitrary, which this bug report is about:

Nextcloud Group Sorting (External Storage panel)

Nextcloud 29 did a massive improvement of the visual presentation in the user panel. I wish the same dropdown design was used in the external storage panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants